From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Matheus Tavares Bernardino" <quic_mathbern@quicinc.com>,
"Peter Xu" <peterx@redhat.com>, "Fabiano Rosas" <farosas@suse.de>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] tests/functional/test_migration: Use "ncat" instead of "nc" in the exec test
Date: Wed, 19 Mar 2025 13:03:18 +0100 [thread overview]
Message-ID: <a5f66f3b-1070-4021-9616-beea78a2be1d@linaro.org> (raw)
In-Reply-To: <20250319105617.133191-1-thuth@redhat.com>
On 19/3/25 11:56, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> "nc" can either bei GNU netcat, OpenBSD netcat or NMap ncat. At
> least GNU netcat currently does not work with this test anymore,
> though the comment in the test says otherwise. GNU netcat seems
> to be quite unmaintained nowadays, according to its website
> (https://netcat.sourceforge.net/), the last public release is from
> 2004, so we should rather avoid that binary.
> In our CI, we are only using "ncat" in the containers (it's the only
> flavor that lcitool supports), thus to avoid silent regressions with
> the other netcats, let's limit this test to "ncat" only now.
>
> Reported-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/test_migration.py | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-03-19 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 10:56 [PATCH] tests/functional/test_migration: Use "ncat" instead of "nc" in the exec test Thomas Huth
2025-03-19 11:55 ` Matheus Tavares Bernardino
2025-03-19 12:03 ` Philippe Mathieu-Daudé [this message]
2025-03-19 12:05 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f66f3b-1070-4021-9616-beea78a2be1d@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).