From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
clg@kaod.org
Subject: Re: [PATCH v5 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2
Date: Thu, 22 Feb 2024 15:04:44 +0530 [thread overview]
Message-ID: <a60f2ec8-52ff-4c00-948c-438ed6bc66a0@linux.ibm.com> (raw)
In-Reply-To: <7f3984701b06b581f72b39dd8bd804bb128982b1.1705614747.git.balaton@eik.bme.hu>
On 1/19/24 03:31, BALATON Zoltan wrote:
> Remove check for !defined(CONFIG_USER_ONLY) as this is already within
> an #ifndef CONFIG_USER_ONLY block.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> ---
> target/ppc/excp_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index d8eab4ff6c..2d4a72883f 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2607,7 +2607,7 @@ void helper_hrfid(CPUPPCState *env)
> }
> #endif /* TARGET_PPC64 */
>
> -#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
> +#ifdef TARGET_PPC64
> void helper_rfebb(CPUPPCState *env, target_ulong s)
> {
> target_ulong msr = env->msr;
> @@ -2682,7 +2682,7 @@ void raise_ebb_perfm_exception(CPUPPCState *env)
>
> do_ebb(env, POWERPC_EXCP_PERFM_EBB);
> }
> -#endif /* defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) */
> +#endif /* TARGET_PPC64 */
>
> /*****************************************************************************/
> /* Embedded PowerPC specific helpers */
next prev parent reply other threads:[~2024-02-22 9:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 22:01 [PATCH v5 0/9] Misc clean ups to target/ppc exception handling BALATON Zoltan
2024-01-18 22:01 ` [PATCH v5 1/9] target/ppc: Use env_cpu for cpu_abort in excp_helper BALATON Zoltan
2024-02-21 9:10 ` Harsh Prateek Bora
2024-01-18 22:01 ` [PATCH v5 2/9] target/ppc: Readability improvements in exception handlers BALATON Zoltan
2024-01-18 22:01 ` [PATCH v5 3/9] target/ppc: Fix gen_sc to use correct nip BALATON Zoltan
2024-01-18 22:01 ` [PATCH v5 4/9] target/ppc: Move patching nip from exception handler to helper_scv BALATON Zoltan
2024-01-18 22:01 ` [PATCH v5 5/9] target/ppc: Simplify syscall exception handlers BALATON Zoltan
2024-02-21 9:20 ` Harsh Prateek Bora
2024-02-21 9:42 ` Harsh Prateek Bora
2024-01-18 22:01 ` [PATCH v5 6/9] target/ppc: Clean up ifdefs in excp_helper.c, part 1 BALATON Zoltan
2024-02-22 9:31 ` Harsh Prateek Bora
2024-01-18 22:01 ` [PATCH v5 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2 BALATON Zoltan
2024-02-22 9:34 ` Harsh Prateek Bora [this message]
2024-01-18 22:01 ` [PATCH v5 8/9] target/ppc: Clean up ifdefs in excp_helper.c, part 3 BALATON Zoltan
2024-02-22 9:38 ` Harsh Prateek Bora
2024-01-18 22:01 ` [PATCH v5 9/9] target/ppc: Remove interrupt handler wrapper functions BALATON Zoltan
2024-02-22 10:05 ` Harsh Prateek Bora
2024-02-22 10:06 ` Harsh Prateek Bora
2024-02-22 11:15 ` BALATON Zoltan
2024-01-30 21:08 ` [PATCH v5 0/9] Misc clean ups to target/ppc exception handling BALATON Zoltan
2024-02-16 13:24 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a60f2ec8-52ff-4c00-948c-438ed6bc66a0@linux.ibm.com \
--to=harshpb@linux.ibm.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).