From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] exec.c: check memory backend file size with 'size' option
Date: Mon, 31 Oct 2016 18:56:31 +0100 [thread overview]
Message-ID: <a61fd1ae-682c-32d1-a0eb-6c7271f03e5b@redhat.com> (raw)
In-Reply-To: <20161031172314.GD2919@thinpad.lan.raisama.net>
On 31/10/2016 18:23, Eduardo Habkost wrote:
> On Thu, Oct 27, 2016 at 12:22:59PM +0800, Haozhong Zhang wrote:
>> If the memory backend file is not large enough to hold the required 'size',
>> Qemu will report error and exit.
>>
>> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
>
> Applied to machine-next. Thanks!
Also part of my pull request. :)
Paolo
>> ---
>> exec.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/exec.c b/exec.c
>> index a2b371a..264a25f 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -1316,6 +1316,13 @@ static void *file_ram_alloc(RAMBlock *block,
>> goto error;
>> }
>>
>> + if (file_size > 0 && file_size < memory) {
>> + error_setg(errp, "backing store %s size %"PRId64
>> + " does not match 'size' option %"PRIu64,
>> + path, file_size, memory);
>> + goto error;
>> + }
>> +
>> memory = ROUND_UP(memory, block->page_size);
>>
>> /*
>> --
>> 2.10.1
>>
>>
>
next prev parent reply other threads:[~2016-10-31 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 4:22 [Qemu-devel] [PATCH v2 0/3] Improve truncation behavior of memory-backend-file Haozhong Zhang
2016-10-27 4:22 ` [Qemu-devel] [PATCH v2 1/3] exec.c: do not truncate non-empty memory backend file Haozhong Zhang
2016-10-27 14:31 ` Eduardo Habkost
2016-10-28 2:07 ` Haozhong Zhang
2016-10-31 17:21 ` Eduardo Habkost
2016-10-27 4:22 ` [Qemu-devel] [PATCH v2 2/3] exec.c: check memory backend file size with 'size' option Haozhong Zhang
2016-10-27 14:32 ` Eduardo Habkost
2016-10-31 17:23 ` Eduardo Habkost
2016-10-31 17:56 ` Paolo Bonzini [this message]
2016-11-02 1:05 ` [Qemu-devel] [RESEND PATCH " Haozhong Zhang
2016-10-27 4:23 ` [Qemu-devel] [PATCH v2 3/3] hostmem-file: make option 'size' optional Haozhong Zhang
2016-10-27 14:55 ` Eduardo Habkost
2016-10-28 2:06 ` Haozhong Zhang
2016-10-28 5:57 ` Haozhong Zhang
2016-10-31 18:18 ` Eduardo Habkost
2016-11-02 2:08 ` Haozhong Zhang
2016-10-27 12:03 ` [Qemu-devel] [PATCH v2 0/3] Improve truncation behavior of memory-backend-file Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a61fd1ae-682c-32d1-a0eb-6c7271f03e5b@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).