* [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable
@ 2022-03-11 7:43 Cédric Le Goater
2022-03-11 7:45 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Cédric Le Goater @ 2022-03-11 7:43 UTC (permalink / raw)
To: qemu-ppc, qemu-devel; +Cc: Thomas Huth, Cédric Le Goater
Xive2EndSource objects can only be instantiated through a Xive2Router
(PnvXive2).
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/intc/xive2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
index b6452f14784b..3aff42a69ef5 100644
--- a/hw/intc/xive2.c
+++ b/hw/intc/xive2.c
@@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
dc->desc = "XIVE END Source";
device_class_set_props(dc, xive2_end_source_properties);
dc->realize = xive2_end_source_realize;
+ dc->user_creatable = false;
}
static const TypeInfo xive2_end_source_info = {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable
2022-03-11 7:43 [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable Cédric Le Goater
@ 2022-03-11 7:45 ` Thomas Huth
2022-03-11 7:46 ` Cédric Le Goater
2022-03-13 14:00 ` Philippe Mathieu-Daudé
2022-03-14 15:20 ` Cédric Le Goater
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2022-03-11 7:45 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc, qemu-devel
On 11/03/2022 08.43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/intc/xive2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
> index b6452f14784b..3aff42a69ef5 100644
> --- a/hw/intc/xive2.c
> +++ b/hw/intc/xive2.c
> @@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
> dc->desc = "XIVE END Source";
> device_class_set_props(dc, xive2_end_source_properties);
> dc->realize = xive2_end_source_realize;
> + dc->user_creatable = false;
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable
2022-03-11 7:45 ` Thomas Huth
@ 2022-03-11 7:46 ` Cédric Le Goater
0 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2022-03-11 7:46 UTC (permalink / raw)
To: Thomas Huth, qemu-ppc, qemu-devel
On 3/11/22 08:45, Thomas Huth wrote:
> On 11/03/2022 08.43, Cédric Le Goater wrote:
>> Xive2EndSource objects can only be instantiated through a Xive2Router
>> (PnvXive2).
>>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> hw/intc/xive2.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
>> index b6452f14784b..3aff42a69ef5 100644
>> --- a/hw/intc/xive2.c
>> +++ b/hw/intc/xive2.c
>> @@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
>> dc->desc = "XIVE END Source";
>> device_class_set_props(dc, xive2_end_source_properties);
>> dc->realize = xive2_end_source_realize;
>> + dc->user_creatable = false;
>> }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
And,
Fixes: f8a233dedf25 ("ppc/xive2: Introduce a XIVE2 core framework")
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable
2022-03-11 7:43 [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable Cédric Le Goater
2022-03-11 7:45 ` Thomas Huth
@ 2022-03-13 14:00 ` Philippe Mathieu-Daudé
2022-03-14 15:20 ` Cédric Le Goater
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-13 14:00 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc, qemu-devel; +Cc: Thomas Huth
On 11/3/22 08:43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
Reported-by?
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/intc/xive2.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable
2022-03-11 7:43 [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable Cédric Le Goater
2022-03-11 7:45 ` Thomas Huth
2022-03-13 14:00 ` Philippe Mathieu-Daudé
@ 2022-03-14 15:20 ` Cédric Le Goater
2 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2022-03-14 15:20 UTC (permalink / raw)
To: qemu-ppc, qemu-devel; +Cc: Thomas Huth
On 3/11/22 08:43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/intc/xive2.c | 1 +
> 1 file changed, 1 insertion(+)
Queued for 7.0
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-14 15:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-11 7:43 [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable Cédric Le Goater
2022-03-11 7:45 ` Thomas Huth
2022-03-11 7:46 ` Cédric Le Goater
2022-03-13 14:00 ` Philippe Mathieu-Daudé
2022-03-14 15:20 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).