From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
vsementsov@virtuozzo.com, berrange@redhat.com,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-nbd: Document --tls-creds
Date: Wed, 3 Oct 2018 16:35:35 -0400 [thread overview]
Message-ID: <a6439e4c-a5ac-ed0a-0d6f-2dac91c0f93f@redhat.com> (raw)
In-Reply-To: <20181003180426.602765-1-eblake@redhat.com>
On 10/03/2018 02:04 PM, Eric Blake wrote:
> Commit 145614a1 introduced --tls-creds, but forgot to document
> it in 'qemu-nbd --help'.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> ---
> Sadly, 'git grep -i "qemu.nbd.*tls"' has no hits, making me wonder
> if our iotests are even covering this.
>
> Noticed while writing my other patches for defaulting to newstyle.
> ---
> qemu-nbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 51b9d38c727..66e023f7fa4 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -94,6 +94,7 @@ static void usage(const char *name)
> "General purpose options:\n"
> " --object type,id=ID,... define an object such as 'secret' for providing\n"
> " passwords and/or encryption keys\n"
> +" --tls-creds=ID use id of an earlier --object to provide TLS\n"
> " -T, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> " specify tracing options\n"
> " --fork fork off the server process and exit the parent\n"
>
Reviewed-by: John Snow <jsnow@redhat.com>
Do we have a manpage/texi that needs to update, too?
next prev parent reply other threads:[~2018-10-03 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 18:04 [Qemu-devel] [PATCH] qemu-nbd: Document --tls-creds Eric Blake
2018-10-03 20:35 ` John Snow [this message]
2018-10-03 20:42 ` [Qemu-devel] [Qemu-block] " Eric Blake
2018-10-03 20:44 ` John Snow
2018-10-03 20:44 ` [Qemu-devel] " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6439e4c-a5ac-ed0a-0d6f-2dac91c0f93f@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).