From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, cohuck@redhat.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support
Date: Wed, 27 Sep 2017 10:51:11 -0700 [thread overview]
Message-ID: <a64a96b3-436f-537f-a352-428d449bba01@linaro.org> (raw)
In-Reply-To: <20170927170027.8539-3-david@redhat.com>
On 09/27/2017 10:00 AM, David Hildenbrand wrote:
> + case PSW_ASC_HOME:
> + return !(env->cregs[13] & _ASCE_PRIVATE_SPACE);
> + default:
> + /* We don't support access register mode */
> + error_report("unsupported addressing mode");
> + exit(1);
I think g_assert_not_reached() is sufficient for cases like this.
Oh, it's just code movement. Nevermind, perhaps.
Modulo the outcome of discussion on patch 1,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2017-09-27 17:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 17:00 [Qemu-devel] [PATCH RFC 0/3] s390x/tcg: LAP support using immediate TLB invalidation David Hildenbrand
2017-09-27 17:00 ` [Qemu-devel] [PATCH RFC 1/3] accel/tcg: allow to invalidate a write TLB entry immediately David Hildenbrand
2017-09-27 17:48 ` Richard Henderson
2017-09-27 18:50 ` David Hildenbrand
2017-10-16 7:24 ` David Hildenbrand
2017-10-16 18:06 ` Richard Henderson
2017-09-27 17:00 ` [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support David Hildenbrand
2017-09-27 17:51 ` Richard Henderson [this message]
2017-09-28 4:50 ` Thomas Huth
2017-09-28 13:08 ` David Hildenbrand
2017-09-29 11:27 ` Cornelia Huck
2017-10-12 8:41 ` Thomas Huth
2017-10-16 7:20 ` David Hildenbrand
2017-09-27 17:00 ` [Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the lowcore David Hildenbrand
2017-09-27 17:52 ` Richard Henderson
2017-09-27 18:46 ` David Hildenbrand
2017-09-28 4:23 ` Thomas Huth
2017-09-29 12:43 ` Cornelia Huck
2017-09-29 11:49 ` [Qemu-devel] [PATCH RFC 0/3] s390x/tcg: LAP support using immediate TLB invalidation Cornelia Huck
2017-09-29 12:09 ` David Hildenbrand
2017-09-29 12:13 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a64a96b3-436f-537f-a352-428d449bba01@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).