From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0tIE-0002Sk-Ob for qemu-devel@nongnu.org; Mon, 04 Mar 2019 14:30:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0tID-0008Cl-Sy for qemu-devel@nongnu.org; Mon, 04 Mar 2019 14:30:30 -0500 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:37301) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0tID-0008AS-Aj for qemu-devel@nongnu.org; Mon, 04 Mar 2019 14:30:29 -0500 Received: by mail-pg1-x532.google.com with SMTP id q206so3775451pgq.4 for ; Mon, 04 Mar 2019 11:30:27 -0800 (PST) References: <20190301214945.4353-1-palmer@sifive.com> <36b17c57-7caf-1e49-d500-bf2eddcd1f25@mail.uni-paderborn.de> From: Richard Henderson Message-ID: Date: Mon, 4 Mar 2019 11:30:21 -0800 MIME-Version: 1.0 In-Reply-To: <36b17c57-7caf-1e49-d500-bf2eddcd1f25@mail.uni-paderborn.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] target/riscv: Convert to decodetree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , Peter Maydell , Palmer Dabbelt Cc: "open list:RISC-V" , QEMU Developers On 3/4/19 4:52 AM, Bastian Koppelmann wrote: > This looks like an unforeseen decodetree problem (CC' Richard). As these 16/32 > instructions share the same trans_* function, we emit the same typedef once for > 16 bit and once for 32 bit. I don't see an easy fix in decodetree Use an argument set, and add !extern to the argument set definition for the "second" decoder. (Leastwise I don't think that feature is sitting on the branch...) r~