From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-trivial@nongnu.org,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Coiby Xu" <Coiby.Xu@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it
Date: Fri, 10 Feb 2023 13:39:20 +0100 [thread overview]
Message-ID: <a65c42ff-6e96-1051-558d-91c84432b5e8@linaro.org> (raw)
In-Reply-To: <20230210111931.1115489-1-thuth@redhat.com>
On 10/2/23 12:19, Thomas Huth wrote:
> Include it in the .c files instead that use the error reporting
> functions.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> RFC since it's more lines of code - but I think it's still cleaner
> this way.
This is less pressure on the various .c files including these .h,
so it is an improvement IMO.
> include/hw/arm/allwinner-a10.h | 1 -
> include/qemu/vhost-user-server.h | 1 -
> include/ui/console.h | 1 -
> hw/display/vhost-user-gpu.c | 1 +
> hw/display/virtio-gpu-virgl.c | 1 +
> hw/misc/applesmc.c | 1 +
> ui/console.c | 1 +
> ui/egl-headless.c | 1 +
> ui/spice-app.c | 1 +
> ui/spice-display.c | 1 +
> ui/udmabuf.c | 1 +
> ui/vdagent.c | 1 +
> util/vhost-user-server.c | 1 +
> 13 files changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-02-10 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 11:19 [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it Thomas Huth
2023-02-10 12:39 ` Philippe Mathieu-Daudé [this message]
2023-02-10 13:43 ` Markus Armbruster
2023-02-13 14:24 ` Thomas Huth
2023-02-13 14:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65c42ff-6e96-1051-558d-91c84432b5e8@linaro.org \
--to=philmd@linaro.org \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).