From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86681C05027 for ; Fri, 10 Feb 2023 12:39:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQSgc-0003FJ-Dj; Fri, 10 Feb 2023 07:39:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQSgY-0003Ed-5o for qemu-devel@nongnu.org; Fri, 10 Feb 2023 07:39:28 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQSgV-0003um-Vl for qemu-devel@nongnu.org; Fri, 10 Feb 2023 07:39:25 -0500 Received: by mail-wr1-x42f.google.com with SMTP id o18so4955923wrj.3 for ; Fri, 10 Feb 2023 04:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aNsvsSAqwcg+4xbViCFC+/j3Ki0z4tY5GQRWMiE6ROI=; b=R7VLD82W8+phs23c/3pOt7HebcDyz+RAnfrRyQq+/IwpVordqzLpC6OMNIK3bIKu4V 3dBdf3Na0D0Np2537n9KyAozG5qEKHhMe3+gcTEnjWIXIe2XclezffZQl/P3CW7BZ6DO bL9bfYf27Q9vqpjUXUlbr/sdKfz9MJNuL8bjuD3Y8UKGMHrqbfQ3h/NyzW13COQtyxdZ y9YSkACCk7cU85QS19LP5Aqqf+smJw8vVDGvxuaZQrmijIm5ERZfvu+vAQYfi5cFLaDP pDfTP2buKFkPu1U9tM9o0jTUvs2bnQeJQnJEk/IrKVAvyip/vl650A/IBrLW+LQ0iqTa sAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aNsvsSAqwcg+4xbViCFC+/j3Ki0z4tY5GQRWMiE6ROI=; b=PhuufUO0hn4BvKrccglJMPD+reyg1F5JPG5LYROkdjKF91MdipYkrM8aCkDra5Ks9j bcvXtUZkbKiBIImxG11kh9ZzcMTkDlvY5xesYysVD+GHqC89lSRQwUQpdlTAT+4Rhh4F 9BUe3FCNPISnAoFmHif/UMecGc6Pdbh7pnDQuNwl/Vr7+lTdp36+smmfzLUle3tvc1YF +pXclcjo+s4Vt0PQ8O+bnZ9F5WLPIUE6RLN3zG6+6VE21TpZV2iPkTOV5/kUmfriPei0 bvyko1hoYP/rV3+rXQQgEaSzg4rD7mH/D+EMnLIOOxHCs/NQTqEM/I9LmD80qyWHymGj QPCA== X-Gm-Message-State: AO0yUKWLIyv0WYYy16aHna+LbXVHSFwKszZ8A7XwWGyLl2j7Djdt8nYh Lki9XhOFlg/qHYPjqweXYfUz+g== X-Google-Smtp-Source: AK7set/oWm69VERfmHNj+gfJ47eo94tn/HuBH9/yrAlsYlU6MsTFu0zMznyFpMCL0PciPL+FYS9KAg== X-Received: by 2002:adf:f350:0:b0:2c3:da3f:1def with SMTP id e16-20020adff350000000b002c3da3f1defmr15690303wrp.7.1676032762461; Fri, 10 Feb 2023 04:39:22 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id d15-20020a056000114f00b002c53e8d86basm2946009wrx.83.2023.02.10.04.39.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 04:39:22 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 13:39:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it Content-Language: en-US To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-trivial@nongnu.org, Beniamino Galvani , Peter Maydell , Strahinja Jankovic , Coiby Xu , Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Markus Armbruster References: <20230210111931.1115489-1-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230210111931.1115489-1-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.149, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/2/23 12:19, Thomas Huth wrote: > Include it in the .c files instead that use the error reporting > functions. > > Signed-off-by: Thomas Huth > --- > RFC since it's more lines of code - but I think it's still cleaner > this way. This is less pressure on the various .c files including these .h, so it is an improvement IMO. > include/hw/arm/allwinner-a10.h | 1 - > include/qemu/vhost-user-server.h | 1 - > include/ui/console.h | 1 - > hw/display/vhost-user-gpu.c | 1 + > hw/display/virtio-gpu-virgl.c | 1 + > hw/misc/applesmc.c | 1 + > ui/console.c | 1 + > ui/egl-headless.c | 1 + > ui/spice-app.c | 1 + > ui/spice-display.c | 1 + > ui/udmabuf.c | 1 + > ui/vdagent.c | 1 + > util/vhost-user-server.c | 1 + > 13 files changed, 10 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé