From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBNW4-0007L4-U7 for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:06:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBNW1-00058T-4w for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:06:48 -0500 Sender: Paolo Bonzini References: <20161127162817.15144-1-bunk@stusta.de> From: Paolo Bonzini Message-ID: Date: Mon, 28 Nov 2016 16:05:33 +0100 MIME-Version: 1.0 In-Reply-To: <20161127162817.15144-1-bunk@stusta.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adrian Bunk , qemu-devel@nongnu.org, qemu-trivial@nongnu.org On 27/11/2016 17:28, Adrian Bunk wrote: > Building qemu fails in distributions where gcc enables PIE > by default (e.g. Debian unstable) with: > /usr/bin/ld: -r and -pie may not be used together > > -r and -pie cannot be used together in the linker, > and position independent is already relocatable. > > Use -r instead of -Wl,-r to avoid gcc passing -r to the > linker when PIE is enabled. > > Signed-off-by: Adrian Bunk I think this is a bug in the linker. If the linker is producing relocatable objects by default, it has no reason to refuse -r. Have you tried asking the binutils folks about it too? But the patch would probably remove the need for LD_REL_FLAGS, based on a quick look at the GCC source code, so I guess it's fine. Paolo > --- > rules.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules.mak b/rules.mak > index 0333ae3..545ebd9 100644 > --- a/rules.mak > +++ b/rules.mak > @@ -93,7 +93,7 @@ module-common.o: CFLAGS += $(DSO_OBJ_CFLAGS) > $(if $(findstring /,$@),$(call quiet-command,cp $@ $(subst /,-,$@),"CP","$(subst /,-,$@)")) > > > -LD_REL := $(CC) -nostdlib -Wl,-r $(LD_REL_FLAGS) > +LD_REL := $(CC) -nostdlib -r $(LD_REL_FLAGS) > > %.mo: > $(call quiet-command,$(LD_REL) -o $@ $^,"LD","$(TARGET_DIR)$@") >