From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CB74C54E64 for ; Thu, 28 Mar 2024 15:22:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpraT-0005FN-Dy; Thu, 28 Mar 2024 11:22:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpraO-0005BZ-SY for qemu-devel@nongnu.org; Thu, 28 Mar 2024 11:22:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpraN-0004K9-7s for qemu-devel@nongnu.org; Thu, 28 Mar 2024 11:22:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711639354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DaMXkCeVFLN+OWi/cxJMIO47GxBHvCsF2o+qAtNFLjw=; b=i8hFrCcuP36ubRyZi5CLpYpW7zx9Ld/2EJNPP/fasozIxgIiC3uVPwsXwU4uqUS6csxkQm Y0bv0PnFbTIOguskb7nqo9DBMsGn2GeaoEjxfz1nBmCs6KipJg0XJgdtjqCLXeFO6PRmHs tYnwzCBtW9piUQ2t7RjV6n7uJ8aebWc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-Raot8RxvNFmHN3dW55vvcA-1; Thu, 28 Mar 2024 11:22:31 -0400 X-MC-Unique: Raot8RxvNFmHN3dW55vvcA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41485831b2dso7759325e9.3 for ; Thu, 28 Mar 2024 08:22:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711639350; x=1712244150; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DaMXkCeVFLN+OWi/cxJMIO47GxBHvCsF2o+qAtNFLjw=; b=s30+rUu1l4Hr26Ht+oKkFb2SEj8qkbEDLxXhkgZ3NyvzaOm/bK47dWhRvmIumLZWlh enpyrD1dBxiBKS7t3GzuKqlpeKnZkABZJhUdS1+7PNO4dmSUx2AsB+TUgRLrHMJvP8s0 dBHpy+UU2nQY+Rvkz0AGB12Kmqrc17mxHtsbzoHG/A/gUlRPnzD3rIf6k1gW1aW6NZ21 kSSprXW67dXzQFF1clMPwVTkvGpB3vT6w9UHU0i4BbQMgVE6AZ8ZOzJ80INQzkTjjVjw dtXyLUD6yCIrASUmXVEInbQQWCbTPNVW1j6NCaV09SBNvJvE9A6G2fehqmrxWL5CbSps BQGw== X-Forwarded-Encrypted: i=1; AJvYcCWi4Y65wEYEJ+tGGbQmNmQdD+aVSzwDqC30F+u2dzMo8wD1wm2Z2kPo047ozWC5235xbkllQUkRzSlFW95YKLa8d3YAqdU= X-Gm-Message-State: AOJu0YwbW02n6XLcLheVycv+2XtaiRaviUxN+6tIatYGOQo/yQ+0V5xO 7pi+kY/sIaH2jvgYIUUzQGpQUOZlR4+3M+oIML3U6kdHzR4a3S7veRxQTHY0kijFTcTz5wPbAli 2dcD7OMs71BBQHYCZcD+Qtbm2aNM0WGkcooCOJBShkm/NRo+lIRPn X-Received: by 2002:a05:600c:3111:b0:414:9048:409d with SMTP id g17-20020a05600c311100b004149048409dmr3442394wmo.15.1711639350667; Thu, 28 Mar 2024 08:22:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCCiWxuH9dGlJmEKz4nIe6dYWj9gtIdTo1OXagxcWpvg+yxZBr+fnxyj4dORgRk/PsEC8YUw== X-Received: by 2002:a05:600c:3111:b0:414:9048:409d with SMTP id g17-20020a05600c311100b004149048409dmr3442364wmo.15.1711639350255; Thu, 28 Mar 2024 08:22:30 -0700 (PDT) Received: from [192.168.0.9] (ip-109-43-177-37.web.vodafone.de. [109.43.177.37]) by smtp.gmail.com with ESMTPSA id fc9-20020a05600c524900b004154399fbd9sm2711613wmb.45.2024.03.28.08.22.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 08:22:29 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 16:22:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling To: Peter Xu , Fabiano Rosas Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Yuval Shaia , Kevin Wolf , Prasanna Kumar Kalever , Cornelia Huck , Michael Roth , Li Zhijian , Prasanna Kumar Kalever , integration@gluster.org, Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , devel@lists.libvirt.org, Hanna Reitz , "Michael S. Tsirkin" , Eric Blake , Song Gao , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Markus Armbruster , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Wainer dos Santos Moschetta , Beraldo Leal , Peter Maydell , Yu Zhang References: <20240328130255.52257-1-philmd@linaro.org> <20240328130255.52257-3-philmd@linaro.org> <87frwatp7n.fsf@suse.de> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.08, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/03/2024 16.01, Peter Xu wrote: > On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote: >> Philippe Mathieu-Daudé writes: >> >>> The whole RDMA subsystem was deprecated in commit e9a54265f5 >>> ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") >>> released in v8.2. >>> >>> Remove: >>> - RDMA handling from migration >>> - dependencies on libibumad, libibverbs and librdmacm >>> >>> Keep the RAM_SAVE_FLAG_HOOK definition since it might appears >>> in old migration streams. >>> >>> Cc: Peter Xu >>> Cc: Li Zhijian >>> Acked-by: Fabiano Rosas >>> Signed-off-by: Philippe Mathieu-Daudé >> >> Just to be clear, because people raised the point in the last version, >> the first link in the deprecation commit links to a thread comprising >> entirely of rdma migration patches. I don't see any ambiguity on whether >> the deprecation was intended to include migration. There's even an ack >> from Juan. > > Yes I remember that's the plan. > >> >> So on the basis of not reverting the previous maintainer's decision, my >> Ack stands here. >> >> We also had pretty obvious bugs ([1], [2]) in the past that would have >> been caught if we had any kind of testing for the feature, so I can't >> even say this thing works currently. >> >> @Peter Xu, @Li Zhijian, what are your thoughts on this? > > Generally I definitely agree with such a removal sooner or later, as that's > how deprecation works, and even after Juan's left I'm not aware of any > other new RDMA users. Personally, I'd slightly prefer postponing it one > more release which might help a bit of our downstream maintenance, however > I assume that's not a blocker either, as I think we can also manage it. > > IMHO it's more important to know whether there are still users and whether > they would still like to see it around. Since e9a54265f5 was not very clear about rdma migration code, should we maybe rather add a separate deprecation note for the migration part, and add a proper warning message to the migration code in case someone tries to use it there, and then only remove the rdma migration code after two more releases? Thomas