From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Denis Lunev <den@virtuozzo.com>
Subject: Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap
Date: Mon, 9 Dec 2019 18:58:22 +0100 [thread overview]
Message-ID: <a67b4a16-773c-52c8-288a-0e9e032b4589@redhat.com> (raw)
In-Reply-To: <cbba2b12-da7d-eed8-1f6b-fc2412f82ff8@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1032 bytes --]
On 09.12.19 17:30, Max Reitz wrote:
> On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote:
>> Hi again!
>>
>> Still forgotten bug-fix :(
>>
>> Is it too late for 4.2?
>
> Sorry. :-/
>
> Yes, I think I just forgot it. I don’t think it’s too important for
> 4.2, so, well, it isn’t too bad, but... Sorry.
>
>> I can't imagine better test, and it tests exactly what written in
>> https://bugzilla.redhat.com/show_bug.cgi?id=1712636
>>
>> (Hmm, actually, I doubt that it is real use-case, more probably it's a bug in management layer)
>>
>> So, take this with test or without test, to 4.2 or 5.0.
>
> I was thinking of seeing whether I could write a quicker test, but of
> course we should take the patch either way.
OK, I give up. It’s very much possible to create an image with 65535
bitmaps very quickly (like, under a second) outside of qemu, but just
opening it takes 2:30 min (because of the quadratic complexity of
checking whether a bitmap of the same name already exists).
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-09 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 11:51 [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2019-10-14 11:51 ` [PATCH v2 1/2] qcow2-bitmaps: " Vladimir Sementsov-Ogievskiy
2019-10-25 12:50 ` Max Reitz
2019-10-25 12:56 ` Vladimir Sementsov-Ogievskiy
2019-12-09 16:32 ` Max Reitz
2019-10-14 11:51 ` [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2 Vladimir Sementsov-Ogievskiy
2019-10-25 13:12 ` Max Reitz
2019-11-16 9:41 ` Vladimir Sementsov-Ogievskiy
2019-10-14 11:52 ` [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2019-10-25 9:57 ` [bugfix ping] " Vladimir Sementsov-Ogievskiy
2019-12-02 14:09 ` [bugfix ping2] " Vladimir Sementsov-Ogievskiy
2019-12-09 16:30 ` Max Reitz
2019-12-09 17:58 ` Max Reitz [this message]
2019-12-09 22:03 ` Eric Blake
2019-12-10 8:11 ` Max Reitz
2019-12-10 13:24 ` Max Reitz
2019-12-10 20:27 ` John Snow
2019-12-11 8:10 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67b4a16-773c-52c8-288a-0e9e032b4589@redhat.com \
--to=mreitz@redhat.com \
--cc=den@virtuozzo.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).