From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC0FC433DF for ; Tue, 19 May 2020 21:51:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7DAF2072C for ; Tue, 19 May 2020 21:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vd9MBlZt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7DAF2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbA9C-0004o5-16 for qemu-devel@archiver.kernel.org; Tue, 19 May 2020 17:51:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbA23-0003Bk-JG for qemu-devel@nongnu.org; Tue, 19 May 2020 17:44:15 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:40664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbA22-0000qW-F0 for qemu-devel@nongnu.org; Tue, 19 May 2020 17:44:15 -0400 Received: by mail-pg1-x543.google.com with SMTP id j21so425360pgb.7 for ; Tue, 19 May 2020 14:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9QcMFgsFvzqpgsVcZKpwWLbbm/tGcQLwiZS5izOUzYE=; b=vd9MBlZtV+8wTXdpyza/bAuEjRjZYzHCAB8h81RBR/znISaOjbHq4Bh7dQBkBcl8H8 LtWYqnj3+U2OBkvWxECfrIzcpergK7GFxDlqNDRghvJesCwi/Jl3Ji8CP7VgYvuQaeyY AaKbkCGSQRbjktlZU/KExpExN4J3wrBZIBZ68WhhJ+oZHiNomMmjewRZPDSjZJJO+kCH zmFaDwyb4yn3ZYGQMit8nC/pO2ncvP97ZtGFdNoof8p5jrmKyGmBVtGHZVYqF3ekm9EJ Youi9H6HnO5RK9icMjuXJ8pQJTUkxNaBCYkJLphFSEKHc4P7XNPrZHtDGwvMth5gUKvT UKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9QcMFgsFvzqpgsVcZKpwWLbbm/tGcQLwiZS5izOUzYE=; b=HocKhkqD6UZOem2jBiYpqY8lHxRO/GmmtzCVqrnmZz6TU8Vk5rkng3Z484Gy6MUk/i JYwE6VVIYTvXsAocTFgq4RrpmKRGaXZ/O6IU4aGNzzJ4Cj/af54BwXf7AqnQo2sqenoM 8Co6XbJrMPnzEdSG1AoKIduvIk43IvGUxlMDNX+dtRxDfMu9sNx/8NCvQdc+hweqqDpB PHlG+ItBRSvT8yRCM3POqywvg4kv74EN87FwzYd8kzOUHTDznw/AOPKvNag5kC8Ysx+R NUqeqKHwcFAjjplyb9yuwD1onW77XP2t6Md34FHH8K/vTEBQhTkUS00TJ4G5fTylKSbJ /k9A== X-Gm-Message-State: AOAM532q28w/kl026rEU5vegoa2tDzU1jV9U1zOTGqdThpKqbNIhAdsv 8WHRyshF8zLF/rMfUfvPWJA4gw== X-Google-Smtp-Source: ABdhPJxMz3+ZBlNd7xQLhdXPca2Mk3IOo3Ssmjn+oEFlna4w+C+N6H/Qi078VtaJAl/Mn2IE8U9k2w== X-Received: by 2002:a63:e14d:: with SMTP id h13mr1080448pgk.321.1589924652927; Tue, 19 May 2020 14:44:12 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id l192sm355847pfd.169.2020.05.19.14.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 14:44:12 -0700 (PDT) Subject: Re: [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200515170804.5707-1-philmd@redhat.com> <20200515170804.5707-11-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Tue, 19 May 2020 14:44:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200515170804.5707-11-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peter Maydell , Thomas Huth , qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , Chris Wulff , Laurent Vivier , Max Filippov , Aleksandar Markovic , qemu-arm@nongnu.org, Palmer Dabbelt , Michael Walle , Paolo Bonzini , Alistair Francis , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Aleksandar Rikalo , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/15/20 10:08 AM, Philippe Mathieu-Daudé wrote: > +++ b/hw/semihosting/Kconfig > @@ -1,3 +1,5 @@ > > +# default is 'n' > config SEMIHOSTING > - bool > + bool > + depends on TCG > diff --git a/target/arm/Kconfig b/target/arm/Kconfig > new file mode 100644 > index 0000000000..3224cac4ad > --- /dev/null > +++ b/target/arm/Kconfig > @@ -0,0 +1,2 @@ > +config SEMIHOSTING > +   default y if TCG Do you really have to duplicate the TCG condition? r~