* [PATCH] docs/system/keys: fix incorrect reset scaling key binding
@ 2025-08-15 9:00 Nir Lichtman
2025-09-09 9:15 ` Thomas Huth
0 siblings, 1 reply; 7+ messages in thread
From: Nir Lichtman @ 2025-08-15 9:00 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel
Fix incorrect key binding for resetting the graphical frontends scaling
Signed-off-by: Nir Lichtman <nir@lichtman.org>
---
docs/system/keys.rst.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
index c28ae1a..3b5307b 100644
--- a/docs/system/keys.rst.inc
+++ b/docs/system/keys.rst.inc
@@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
* - :kbd:`Ctrl+Alt+-`
- Shrink the screen
- * - :kbd:`Ctrl+Alt+u`
+ * - :kbd:`Ctrl+Alt+0`
- Restore the screen's un-scaled dimensions
* - :kbd:`Ctrl+Alt+n`
--
2.39.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-08-15 9:00 [PATCH] docs/system/keys: fix incorrect reset scaling key binding Nir Lichtman
@ 2025-09-09 9:15 ` Thomas Huth
2025-09-10 8:38 ` Gerd Hoffmann
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2025-09-09 9:15 UTC (permalink / raw)
To: Nir Lichtman, peter.maydell
Cc: qemu-devel, Gerd Hoffmann, Marc-André Lureau
On 15/08/2025 11.00, Nir Lichtman wrote:
> Fix incorrect key binding for resetting the graphical frontends scaling
>
> Signed-off-by: Nir Lichtman <nir@lichtman.org>
> ---
> docs/system/keys.rst.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> index c28ae1a..3b5307b 100644
> --- a/docs/system/keys.rst.inc
> +++ b/docs/system/keys.rst.inc
> @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
> * - :kbd:`Ctrl+Alt+-`
> - Shrink the screen
>
> - * - :kbd:`Ctrl+Alt+u`
> + * - :kbd:`Ctrl+Alt+0`
> - Restore the screen's un-scaled dimensions
Hi,
this unfortunately seems to depend on the graphical front-end: For "-display
gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u instead.
Should we unify them? If so, which is the better key combination?
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-09-09 9:15 ` Thomas Huth
@ 2025-09-10 8:38 ` Gerd Hoffmann
2025-09-10 10:23 ` Nir Lichtman
0 siblings, 1 reply; 7+ messages in thread
From: Gerd Hoffmann @ 2025-09-10 8:38 UTC (permalink / raw)
To: Thomas Huth
Cc: Nir Lichtman, peter.maydell, qemu-devel, Marc-André Lureau
On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
> On 15/08/2025 11.00, Nir Lichtman wrote:
> > Fix incorrect key binding for resetting the graphical frontends scaling
> >
> > Signed-off-by: Nir Lichtman <nir@lichtman.org>
> > ---
> > docs/system/keys.rst.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> > index c28ae1a..3b5307b 100644
> > --- a/docs/system/keys.rst.inc
> > +++ b/docs/system/keys.rst.inc
> > @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
> > * - :kbd:`Ctrl+Alt+-`
> > - Shrink the screen
> > - * - :kbd:`Ctrl+Alt+u`
> > + * - :kbd:`Ctrl+Alt+0`
> > - Restore the screen's un-scaled dimensions
>
> Hi,
>
> this unfortunately seems to depend on the graphical front-end: For "-display
> gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u
> instead.
>
> Should we unify them? If so, which is the better key combination?
Established convention in various apps is '+' for zoom in, '-' for zoom
out, and '0' for reset to 100% (each combined with the hotkey
modifier(s)). So when changing hotkeys we should follow that I think,
i.e. switch SDL to Ctrl+Alt+0.
my two cents,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-09-10 8:38 ` Gerd Hoffmann
@ 2025-09-10 10:23 ` Nir Lichtman
2025-10-02 18:03 ` Nir Lichtman
2025-10-07 11:47 ` Thomas Huth
0 siblings, 2 replies; 7+ messages in thread
From: Nir Lichtman @ 2025-09-10 10:23 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Thomas Huth, peter.maydell, qemu-devel, Marc-André Lureau
On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote:
> On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
> > On 15/08/2025 11.00, Nir Lichtman wrote:
> > > Fix incorrect key binding for resetting the graphical frontends scaling
> > >
> > > Signed-off-by: Nir Lichtman <nir@lichtman.org>
> > > ---
> > > docs/system/keys.rst.inc | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> > > index c28ae1a..3b5307b 100644
> > > --- a/docs/system/keys.rst.inc
> > > +++ b/docs/system/keys.rst.inc
> > > @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
> > > * - :kbd:`Ctrl+Alt+-`
> > > - Shrink the screen
> > > - * - :kbd:`Ctrl+Alt+u`
> > > + * - :kbd:`Ctrl+Alt+0`
> > > - Restore the screen's un-scaled dimensions
> >
> > Hi,
> >
> > this unfortunately seems to depend on the graphical front-end: For "-display
> > gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u
> > instead.
> >
> > Should we unify them? If so, which is the better key combination?
>
> Established convention in various apps is '+' for zoom in, '-' for zoom
> out, and '0' for reset to 100% (each combined with the hotkey
> modifier(s)). So when changing hotkeys we should follow that I think,
> i.e. switch SDL to Ctrl+Alt+0.
I'll send a patch fixing SDL to use CTRL+ALT+0
Nir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-09-10 10:23 ` Nir Lichtman
@ 2025-10-02 18:03 ` Nir Lichtman
2025-10-07 11:47 ` Thomas Huth
1 sibling, 0 replies; 7+ messages in thread
From: Nir Lichtman @ 2025-10-02 18:03 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Thomas Huth, peter.maydell, qemu-devel, Marc-André Lureau
On Wed, Sep 10, 2025 at 10:23:52AM +0000, Nir Lichtman wrote:
> On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote:
> > On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
> > > On 15/08/2025 11.00, Nir Lichtman wrote:
> > > > Fix incorrect key binding for resetting the graphical frontends scaling
> > > >
> > > > Signed-off-by: Nir Lichtman <nir@lichtman.org>
> > > > ---
> > > > docs/system/keys.rst.inc | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> > > > index c28ae1a..3b5307b 100644
> > > > --- a/docs/system/keys.rst.inc
> > > > +++ b/docs/system/keys.rst.inc
> > > > @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
> > > > * - :kbd:`Ctrl+Alt+-`
> > > > - Shrink the screen
> > > > - * - :kbd:`Ctrl+Alt+u`
> > > > + * - :kbd:`Ctrl+Alt+0`
> > > > - Restore the screen's un-scaled dimensions
> > >
> > > Hi,
> > >
> > > this unfortunately seems to depend on the graphical front-end: For "-display
> > > gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u
> > > instead.
> > >
> > > Should we unify them? If so, which is the better key combination?
> >
> > Established convention in various apps is '+' for zoom in, '-' for zoom
> > out, and '0' for reset to 100% (each combined with the hotkey
> > modifier(s)). So when changing hotkeys we should follow that I think,
> > i.e. switch SDL to Ctrl+Alt+0.
>
> I'll send a patch fixing SDL to use CTRL+ALT+0
>
> Nir
Hi,
Looks like the SDL patch I sent was merged into main,
reminder regarding this patch which fixes the documentation.
Thanks,
Nir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-09-10 10:23 ` Nir Lichtman
2025-10-02 18:03 ` Nir Lichtman
@ 2025-10-07 11:47 ` Thomas Huth
2025-10-10 7:56 ` Michael Tokarev
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2025-10-07 11:47 UTC (permalink / raw)
To: Nir Lichtman, Gerd Hoffmann, QEMU Trivial
Cc: peter.maydell, qemu-devel, Marc-André Lureau
On 10/09/2025 12.23, Nir Lichtman wrote:
> On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote:
>> On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
>>> On 15/08/2025 11.00, Nir Lichtman wrote:
>>>> Fix incorrect key binding for resetting the graphical frontends scaling
>>>>
>>>> Signed-off-by: Nir Lichtman <nir@lichtman.org>
>>>> ---
>>>> docs/system/keys.rst.inc | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
>>>> index c28ae1a..3b5307b 100644
>>>> --- a/docs/system/keys.rst.inc
>>>> +++ b/docs/system/keys.rst.inc
>>>> @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
>>>> * - :kbd:`Ctrl+Alt+-`
>>>> - Shrink the screen
>>>> - * - :kbd:`Ctrl+Alt+u`
>>>> + * - :kbd:`Ctrl+Alt+0`
>>>> - Restore the screen's un-scaled dimensions
>>>
>>> Hi,
>>>
>>> this unfortunately seems to depend on the graphical front-end: For "-display
>>> gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u
>>> instead.
>>>
>>> Should we unify them? If so, which is the better key combination?
>>
>> Established convention in various apps is '+' for zoom in, '-' for zoom
>> out, and '0' for reset to 100% (each combined with the hotkey
>> modifier(s)). So when changing hotkeys we should follow that I think,
>> i.e. switch SDL to Ctrl+Alt+0.
>
> I'll send a patch fixing SDL to use CTRL+ALT+0
Now that the patch for the SDL backend got merged:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
2025-10-07 11:47 ` Thomas Huth
@ 2025-10-10 7:56 ` Michael Tokarev
0 siblings, 0 replies; 7+ messages in thread
From: Michael Tokarev @ 2025-10-10 7:56 UTC (permalink / raw)
To: Thomas Huth, Nir Lichtman, Gerd Hoffmann, QEMU Trivial
Cc: peter.maydell, qemu-devel, Marc-André Lureau
On 10/7/25 14:47, Thomas Huth wrote:
> On 10/09/2025 12.23, Nir Lichtman wrote:
>> On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote:
>>> On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
>>>> On 15/08/2025 11.00, Nir Lichtman wrote:
>>>>> Fix incorrect key binding for resetting the graphical frontends
>>>>> scaling
>>>>>
>>>>> Signed-off-by: Nir Lichtman <nir@lichtman.org>
>>>>> ---
>>>>> docs/system/keys.rst.inc | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
>>>>> index c28ae1a..3b5307b 100644
>>>>> --- a/docs/system/keys.rst.inc
>>>>> +++ b/docs/system/keys.rst.inc
>>>>> @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it
>>>>> to the right :kbd:`Ctrl` key.
>>>>> * - :kbd:`Ctrl+Alt+-`
>>>>> - Shrink the screen
>>>>> - * - :kbd:`Ctrl+Alt+u`
>>>>> + * - :kbd:`Ctrl+Alt+0`
>>>>> - Restore the screen's un-scaled dimensions
>> I'll send a patch fixing SDL to use CTRL+ALT+0
>
> Now that the patch for the SDL backend got merged:
Fixes: 15421f7113 "ui/sdl2: fix reset scaling binding to be consistent
with gtk"
(it'd be nice to merge the two changes together, but ok)
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
And applied to the trivial-patches tree.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-10 7:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-15 9:00 [PATCH] docs/system/keys: fix incorrect reset scaling key binding Nir Lichtman
2025-09-09 9:15 ` Thomas Huth
2025-09-10 8:38 ` Gerd Hoffmann
2025-09-10 10:23 ` Nir Lichtman
2025-10-02 18:03 ` Nir Lichtman
2025-10-07 11:47 ` Thomas Huth
2025-10-10 7:56 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).