From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxea9-0003lc-GN for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:11:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxea8-0003Cs-Nj for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:11:37 -0500 References: <20190223000614.13894-1-jsnow@redhat.com> <20190223000614.13894-4-jsnow@redhat.com> From: Eric Blake Message-ID: Date: Sat, 23 Feb 2019 15:11:15 -0600 MIME-Version: 1.0 In-Reply-To: <20190223000614.13894-4-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Markus Armbruster , Kevin Wolf , vsementsov@virtuozzo.com, Juan Quintela , Max Reitz , libvir-list@redhat.com, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Fam Zheng On 2/22/19 6:06 PM, John Snow wrote: > bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an > internal API by the mirror and migration areas of our code. These > calls modify the bitmap, but do so at the behest of QEMU and not the > guest. > > Presently, these bitmaps are always "enabled" anyway, but there's no > reason they have to be. > > Modify these internal APIs to drop this assertion. > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org