qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org, edgar.iglesias@xilinx.com
Cc: peter.crosthwaite@xilinx.com, alistair.francis@xilinx.com
Subject: [Qemu-devel] [PATCH v2 7/9] ml605_mmu: Move the hardcoded values to the init function
Date: Fri,  5 Jun 2015 16:43:18 +1000	[thread overview]
Message-ID: <a68f8c77202c8c9cb918d1dde6d106d24f19e266.1433481032.git.alistair.francis@xilinx.com> (raw)
In-Reply-To: <cover.1433481032.git.alistair.francis@xilinx.com>

Move the hard coded register values to the init function.
This also allows the entire reset function to be deleted, as
PVR registers are now preserved on reset.

The hardcoded PVR0 values can be removed as they are setting
the endianness and stack protection, which is already done
or invalid.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
V2:
 - Don't set PVR0

 hw/microblaze/petalogix_ml605_mmu.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index 609c90b..ed84a37 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -64,17 +64,6 @@
 #define SPI_IRQ             4
 #define UART16550_IRQ       5
 
-static void machine_cpu_reset(MicroBlazeCPU *cpu)
-{
-    CPUMBState *env = &cpu->env;
-
-    env->pvr.regs[10] = 0x0e000000; /* virtex 6 */
-    /* setup pvr to match kernel setting */
-    env->pvr.regs[0] |= (0x14 << 8);
-    env->pvr.regs[4] = 0xc56b8000;
-    env->pvr.regs[5] = 0xc56be000;
-}
-
 static void
 petalogix_ml605_init(MachineState *machine)
 {
@@ -205,10 +194,15 @@ petalogix_ml605_init(MachineState *machine)
         }
     }
 
+    /* setup PVR to match kernel settings */
+    cpu->env.pvr.regs[4] = 0xc56b8000;
+    cpu->env.pvr.regs[5] = 0xc56be000;
+    cpu->env.pvr.regs[10] = 0x0e000000; /* virtex 6 */
+
     microblaze_load_kernel(cpu, MEMORY_BASEADDR, ram_size,
                            machine->initrd_filename,
                            BINARY_DEVICE_TREE_FILE,
-                           machine_cpu_reset);
+                           NULL);
 
 }
 
-- 
1.7.1

  parent reply	other threads:[~2015-06-05  6:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  6:38 [Qemu-devel] [PATCH v2 0/9] Extend Microblaze Properties Alistair Francis
2015-06-05  6:39 ` [Qemu-devel] [PATCH v2 1/9] target-microblaze: Rename the usefpu variable Alistair Francis
2015-06-05  8:04   ` Peter Crosthwaite
2015-06-09  4:19     ` Alistair Francis
2015-06-05  6:41 ` [Qemu-devel] [PATCH v2 4/9] target-microblaze: Convert endi to a CPU property Alistair Francis
2015-06-15  2:31   ` Peter Crosthwaite
2015-06-15  7:49     ` Alistair Francis
2015-06-05  6:42 ` [Qemu-devel] [PATCH v2 5/9] target-microblaze: Convert version_mask " Alistair Francis
2015-06-15  2:37   ` Peter Crosthwaite
2015-06-05  6:42 ` [Qemu-devel] [PATCH v2 6/9] target-microblaze: Convert pvr-full " Alistair Francis
2015-06-15  2:41   ` Peter Crosthwaite
2015-06-15  7:27     ` Alistair Francis
2015-06-05  6:43 ` Alistair Francis [this message]
2015-06-15  2:43   ` [Qemu-devel] [PATCH v2 7/9] ml605_mmu: Move the hardcoded values to the init function Peter Crosthwaite
2015-06-05  6:43 ` [Qemu-devel] [PATCH v2 8/9] s3adsp1800: Remove the hardcoded values from the reset Alistair Francis
2015-06-15  2:44   ` Peter Crosthwaite
2015-06-05  6:44 ` [Qemu-devel] [PATCH v2 9/9] target-microblaze: Remove dead code Alistair Francis
2015-06-15  2:44   ` Peter Crosthwaite
2015-06-08 23:31 ` [Qemu-devel] [PATCH v2 2/9] target-microblaze: Convert use-mmu to a CPU property Peter Crosthwaite
2015-06-15  2:27   ` Peter Crosthwaite
2015-06-08 23:31 ` [Qemu-devel] [PATCH v2 3/9] target-microblaze: Convert dcache-writeback " Peter Crosthwaite
2015-06-15  2:29   ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a68f8c77202c8c9cb918d1dde6d106d24f19e266.1433481032.git.alistair.francis@xilinx.com \
    --to=alistair.francis@xilinx.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).