From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Luc Michel <luc.michel@amd.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Francisco Iglesias <francisco.iglesias@amd.com>,
"Edgar E . Iglesias" <edgar.iglesias@amd.com>,
Alistair Francis <alistair@alistair23.me>,
Frederic Konrad <frederic.konrad@amd.com>,
Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Subject: Re: [PATCH v2 41/47] hw/arm/xlnx-versal-virt: rename the machine to amd-versal-virt
Date: Wed, 20 Aug 2025 14:30:17 +0200 [thread overview]
Message-ID: <a6a9b8ab-9de5-4d2f-a9eb-7ae9a638df36@linaro.org> (raw)
In-Reply-To: <20250820082549.69724-42-luc.michel@amd.com>
On 20/8/25 10:25, Luc Michel wrote:
> To align with current branding and ensure coherency with the upcoming
> versal2 machine, rename the xlnx-versal-virt machine to amd-versal-virt.
> Keep an alias of the old name to the new one for command-line backward
> compatibility.
>
> Signed-off-by: Luc Michel <luc.michel@amd.com>
> Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>
> ---
> docs/system/arm/xlnx-versal-virt.rst | 26 +++++++++++++++-----------
> hw/arm/xlnx-versal-virt.c | 11 +++++++----
> 2 files changed, 22 insertions(+), 15 deletions(-)
> diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
> index 0f114ade652..4495b20ee1c 100644
> --- a/hw/arm/xlnx-versal-virt.c
> +++ b/hw/arm/xlnx-versal-virt.c
> @@ -1,7 +1,7 @@
> /*
> - * Xilinx Versal Virtual board.
> + * AMD/Xilinx Versal Virtual board.
> *
> * Copyright (c) 2018 Xilinx Inc.
> * Copyright (c) 2025 Advanced Micro Devices, Inc.
> * Written by Edgar E. Iglesias
> *
> @@ -24,11 +24,11 @@
> #include "hw/arm/boot.h"
> #include "target/arm/multiprocessing.h"
> #include "qom/object.h"
> #include "target/arm/cpu.h"
>
> -#define TYPE_XLNX_VERSAL_VIRT_MACHINE MACHINE_TYPE_NAME("xlnx-versal-virt")
> +#define TYPE_XLNX_VERSAL_VIRT_MACHINE MACHINE_TYPE_NAME("amd-versal-virt")
While the alias works, can you also change the machine name in
tests/functional/test_aarch64_xlnx_versal.py in this commit for
clarity?
next prev parent reply other threads:[~2025-08-20 12:32 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:24 [PATCH v2 00/47] AMD Versal Gen 2 support Luc Michel
2025-08-20 8:25 ` [PATCH v2 01/47] hw/arm/xlnx-versal: split the xlnx-versal type Luc Michel
2025-08-20 8:25 ` [PATCH v2 02/47] hw/arm/xlnx-versal: prepare for FDT creation Luc Michel
2025-08-21 13:50 ` Edgar E. Iglesias
2025-08-20 8:25 ` [PATCH v2 03/47] hw/arm/xlnx-versal: uart: refactor creation Luc Michel
2025-08-20 8:25 ` [PATCH v2 04/47] hw/arm/xlnx-versal: canfd: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 05/47] hw/arm/xlnx-versal: sdhci: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 06/47] hw/arm/xlnx-versal: gem: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 07/47] hw/arm/xlnx-versal: adma: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 08/47] hw/arm/xlnx-versal: xram: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 09/47] hw/arm/xlnx-versal: usb: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 10/47] hw/arm/xlnx-versal: efuse: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 11/47] hw/arm/xlnx-versal: ospi: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 12/47] hw/arm/xlnx-versal: VersalMap: add support for OR'ed IRQs Luc Michel
2025-08-20 8:25 ` [PATCH v2 13/47] hw/arm/xlnx-versal: PMC IOU SCLR: refactor creation Luc Michel
2025-08-20 8:25 ` [PATCH v2 14/47] hw/arm/xlnx-versal: bbram: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 15/47] hw/arm/xlnx-versal: trng: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 16/47] hw/arm/xlnx-versal: rtc: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 17/47] hw/arm/xlnx-versal: cfu: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 18/47] hw/arm/xlnx-versal: crl: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 19/47] hw/arm/xlnx-versal-virt: virtio: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 20/47] hw/arm/xlnx-versal: refactor CPU cluster creation Luc Michel
2025-08-20 12:16 ` Philippe Mathieu-Daudé
2025-08-20 12:21 ` Philippe Mathieu-Daudé
2025-08-20 12:49 ` Luc Michel
2025-08-20 8:25 ` [PATCH v2 21/47] hw/arm/xlnx-versal: add the mp_affinity property to the CPU mapping Luc Michel
2025-08-20 12:18 ` Philippe Mathieu-Daudé
2025-08-21 9:59 ` Luc Michel
2025-08-20 8:25 ` [PATCH v2 22/47] hw/arm/xlnx-versal: instantiate the GIC ITS in the APU Luc Michel
2025-08-20 8:25 ` [PATCH v2 23/47] hw/intc/arm_gicv3: Introduce a 'first-cpu-index' property Luc Michel
2025-08-20 8:25 ` [PATCH v2 24/47] hw/arm/xlnx-versal: add support for multiple GICs Luc Michel
2025-08-20 8:25 ` [PATCH v2 25/47] hw/arm/xlnx-versal: add support for GICv2 Luc Michel
2025-08-20 8:25 ` [PATCH v2 26/47] hw/arm/xlnx-versal: rpu: refactor creation Luc Michel
2025-08-20 8:25 ` [PATCH v2 27/47] hw/arm/xlnx-versal: ocm: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 28/47] hw/arm/xlnx-versal: ddr: " Luc Michel
2025-08-20 8:25 ` [PATCH v2 29/47] hw/arm/xlnx-versal: add the versal_get_num_cpu accessor Luc Michel
2025-08-20 8:25 ` [PATCH v2 30/47] hw/misc/xlnx-versal-crl: remove unnecessary include directives Luc Michel
2025-08-20 8:25 ` [PATCH v2 31/47] hw/misc/xlnx-versal-crl: split into base/concrete classes Luc Michel
2025-08-20 8:25 ` [PATCH v2 32/47] hw/misc/xlnx-versal-crl: refactor device reset logic Luc Michel
2025-08-20 8:25 ` [PATCH v2 33/47] hw/arm/xlnx-versal: reconnect the CRL to the other devices Luc Michel
2025-08-20 8:25 ` [PATCH v2 34/47] hw/arm/xlnx-versal: use hw/arm/bsa.h for timer IRQ indices Luc Michel
2025-08-20 12:23 ` Philippe Mathieu-Daudé
2025-08-20 8:25 ` [PATCH v2 35/47] hw/arm/xlnx-versal: tidy up Luc Michel
2025-08-20 8:25 ` [PATCH v2 36/47] hw/misc/xlnx-versal-crl: add the versal2 version Luc Michel
2025-08-20 8:25 ` [PATCH v2 37/47] hw/arm/xlnx-versal: add a per_cluster_gic switch to VersalCpuClusterMap Luc Michel
2025-08-20 8:25 ` [PATCH v2 38/47] hw/arm/xlnx-versal: add the target field in IRQ descriptor Luc Michel
2025-08-20 8:25 ` [PATCH v2 39/47] target/arm/tcg/cpu64: add the cortex-a78ae CPU Luc Michel
2025-08-20 8:25 ` [PATCH v2 40/47] hw/arm/xlnx-versal: add versal2 SoC Luc Michel
2025-08-20 8:25 ` [PATCH v2 41/47] hw/arm/xlnx-versal-virt: rename the machine to amd-versal-virt Luc Michel
2025-08-20 12:26 ` Philippe Mathieu-Daudé
2025-08-20 12:30 ` Philippe Mathieu-Daudé [this message]
2025-08-20 8:25 ` [PATCH v2 42/47] hw/arm/xlnx-versal-virt: split into base/concrete classes Luc Michel
2025-08-20 8:25 ` [PATCH v2 43/47] hw/arm/xlnx-versal-virt: tidy up Luc Michel
2025-08-20 8:25 ` [PATCH v2 44/47] docs/system/arm/xlnx-versal-virt: update supported devices Luc Michel
2025-08-20 8:25 ` [PATCH v2 45/47] docs/system/arm/xlnx-versal-virt: add a note about dumpdtb Luc Michel
2025-08-20 8:25 ` [PATCH v2 46/47] hw/arm/xlnx-versal-virt: add the xlnx-versal2-virt machine Luc Michel
2025-08-20 12:28 ` Philippe Mathieu-Daudé
2025-08-20 8:25 ` [PATCH v2 47/47] tests/functional/test_aarch64_xlnx_versal: test the versal2 machine Luc Michel
2025-08-21 13:54 ` [PATCH v2 00/47] AMD Versal Gen 2 support Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6a9b8ab-9de5-4d2f-a9eb-7ae9a638df36@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@amd.com \
--cc=francisco.iglesias@amd.com \
--cc=frederic.konrad@amd.com \
--cc=luc.michel@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).