From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flv8N-0007SB-Nf for qemu-devel@nongnu.org; Sat, 04 Aug 2018 07:54:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flv8M-00033n-Pi for qemu-devel@nongnu.org; Sat, 04 Aug 2018 07:54:11 -0400 References: <20180729212744.23709-1-lbloch@janustech.com> <20180729212744.23709-7-lbloch@janustech.com> From: Leonid Bloch Message-ID: Date: Sat, 4 Aug 2018 14:53:48 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB-large Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 6/6] qcow2: Resize the cache upon image resizing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz On 08/03/2018 03:42 PM, Alberto Garcia wrote: > On Sun 29 Jul 2018 11:27:44 PM CEST, Leonid Bloch wrote: >> The caches are now recalculated upon image resizing. This is done >> because the new default behavior of assigning a sufficient L2 cache to >> cover the entire image implies that the cache will still be sufficient >> after image resizing. To put a limit on the cache, the options >> cache-size and l2-cache-size can be used. >> >> Signed-off-by: Leonid Bloch >> --- >> block/qcow2.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/block/qcow2.c b/block/qcow2.c >> index 74f2cb10a4..06fac1bb8c 100644 >> --- a/block/qcow2.c >> +++ b/block/qcow2.c >> @@ -3656,6 +3656,12 @@ static int coroutine_fn qcow2_co_truncate(BlockDriverState *bs, int64_t offset, >> } >> >> s->l1_vm_state_index = new_l1_size; >> + /* Update cache sizes */ >> + QDict *options = qdict_clone_shallow(bs->options); >> + ret = qcow2_update_options(bs, options, s->flags, errp); >> + if (ret < 0) { >> + goto fail; >> + } > > Perhaps this could be merged with the "Update total_sectors when > resizing" patch. When you put both changes together it is quite clear > why you need to update bs->total_sectors, and doing it is only necessary > if you want to do this afterwards. Indeed. I agree. Leonid. > > Berto >