qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Cc: Jingqi Liu <jingqi.liu@intel.com>,
	wei.w.wang@intel.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H)
Date: Fri, 6 Jul 2018 11:31:38 +0200	[thread overview]
Message-ID: <a6bac7b6-58b5-6cad-d4c8-01a104465e29@redhat.com> (raw)
In-Reply-To: <20180706084313.GB28022@redhat.com>

On 06/07/2018 10:43, Daniel P. Berrangé wrote:
>> Based on the Linux patch at [1], guests may try to detect the
>> feature by writing to the MSR unconditionally.
>>
>> If this happens, KVM needs to provide a mechanism to
>> enable/disable the MSR emulation.  Otherwise users will end up
>> with VMs that can't be migrated to older hosts even if they are
>> using older machine-types.
> Is there really no CPUID flag that can be used to detect the feature ?
> Unconditionally probing for existance of arbitrary MSRs seems to be
> just re-inventing CPUID feature detection, but worse because as you
> say we need to now invent a way to control existance of individual
> MSRs too :-(

Now that I know that no silicon exists for this feature, the solution is
simple.  The feature will be rejected until a CPUID bit exists.

Paolo

  reply	other threads:[~2018-07-06  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 13:21 [Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H) Jingqi Liu
2018-07-04 13:39 ` Paolo Bonzini
2018-07-06  8:32   ` Liu, Jingqi
2018-07-04 19:43 ` Eduardo Habkost
2018-07-06  8:38   ` Liu, Jingqi
2018-07-06  8:43   ` Daniel P. Berrangé
2018-07-06  9:31     ` Paolo Bonzini [this message]
2018-07-06 11:42       ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6bac7b6-58b5-6cad-d4c8-01a104465e29@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jingqi.liu@intel.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).