Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list

[Paolo Bonzini <pbonzini@redhat.com>]

On 19/10/2018 13:22, Daniel P. Berrangé wrote:
> Copying Paolo, since this probably falls under the "misc patches"
> maintainer bucket.

I think we should define a "generic maintainer stuff" bucket where every
maintainer is supposed to send patches with a Reviewed-by.  Maintainers
are probably good enough at getting reviews by an appropriate person.

(I am slowly trying to remove stuff from the misc bucket).

Paolo

> On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote:
>> In some cases the Author: email address in patches submitted to the
>> list gets mangled such that it says
>>
>>     John Doe via Qemu-devel <qemu-devel@nongnu.org>
>>
>> This change is a result of workarounds for DMARC policies.
>>
>> Subsystem maintainers accepting patches need to catch these and fix
>> them before sending pull requests, so a checkpatch.pl test is highly
>> desirable.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>  scripts/checkpatch.pl | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 42e1c50dd8..be2114a179 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1402,6 +1402,10 @@ sub process {
>>  			$is_patch = 1;
>>  		}
>>  
>> +		if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
>> +		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
>> +		}
>> +
>>  #check the patch for a signoff:
>>  		if ($line =~ /^\s*signed-off-by:/i) {
>>  			# This is a signoff, if ugly, so do not double report.
>> -- 
>> 2.17.1
>>
> 
> Regards,
> Daniel
>