From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwankhede@nvidia.com>) id 1bgDuZ-0001Zq-GY
	for qemu-devel@nongnu.org; Sat, 03 Sep 2016 12:35:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwankhede@nvidia.com>) id 1bgDuU-0006eE-IT
	for qemu-devel@nongnu.org; Sat, 03 Sep 2016 12:35:19 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:18034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwankhede@nvidia.com>) id 1bgDuU-0006dy-AQ
	for qemu-devel@nongnu.org; Sat, 03 Sep 2016 12:35:14 -0400
References: <1472097235-6332-1-git-send-email-kwankhede@nvidia.com>
	<20160830101638.49df467d@t450s.home>
	<AADFC41AFE54684AB9EE6CBC0274A5D18DEBD970@SHSMSX101.ccr.corp.intel.com>
	<78fedd65-6d62-e849-ff3b-d5105b2da816@redhat.com>
	<20160901105948.62f750aa@t450s.home>
	<b4f7b36a-7bca-ef04-e6f5-8b817700250c@redhat.com>
	<98bbdbbf-c388-9120-3306-64f0cfb820a7@nvidia.com>
	<8682faeb-0331-f014-c13e-03c20f3f2bdf@redhat.com>
	<a5476012-0d17-d7bc-b63e-e361b5d7d34e@nvidia.com>
	<f3da1991-f8aa-e330-4b80-509e4f13896b@redhat.com>
	<fde200db-85d2-d979-1f8c-85dada4d6efe@nvidia.com>
	<2a195ed1-f6aa-ffab-3f5c-4121de264d05@redhat.com>
From: Kirti Wankhede <kwankhede@nvidia.com>
Message-ID: <a6e89eeb-84d4-24a3-0782-4202ab298b0e@nvidia.com>
Date: Sat, 3 Sep 2016 22:04:56 +0530
MIME-Version: 1.0
In-Reply-To: <2a195ed1-f6aa-ffab-3f5c-4121de264d05@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Michal Privoznik <mprivozn@redhat.com>, Alex Williamson <alex.williamson@redhat.com>
Cc: "Song, Jike" <jike.song@intel.com>, "cjia@nvidia.com" <cjia@nvidia.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "libvir-list@redhat.com" <libvir-list@redhat.com>, "Tian, Kevin" <kevin.tian@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kraxel@redhat.com" <kraxel@redhat.com>, Laine Stump <laine@redhat.com>, "bjsdjshi@linux.vnet.ibm.com" <bjsdjshi@linux.vnet.ibm.com>



On 9/3/2016 3:18 AM, Paolo Bonzini wrote:
> 
> 
> On 02/09/2016 20:33, Kirti Wankhede wrote:
>> <Alex> We could even do:
>>>>
>>>> echo $UUID1:$GROUPA > create
>>>>
>>>> where $GROUPA is the group ID of a previously created mdev device into
>>>> which $UUID1 is to be created and added to the same group.
>> </Alex>
> 
> From the point of view of libvirt, I think I prefer Alex's idea.
> <group> could be an additional element in the nodedev-create XML:
> 
>     <device>
>       <name>my-vgpu</name>
>       <parent>pci_0000_86_00_0</parent>
>       <capability type='mdev'>
>         <type id='11'/>
>         <uuid>0695d332-7831-493f-9e71-1c85c8911a08</uuid>
>         <group>group1</group>
>       </capability>
>     </device>
> 
> (should group also be a UUID?)
> 

No, this should be a unique number in a system, similar to iommu_group.

> Since John brought up the topic of minimal XML, in this case it will be
> like this:
> 
>     <device>
>       <name>my-vgpu</name>
>       <parent>pci_0000_86_00_0</parent>
>       <capability type='mdev'>
>         <type id='11'/>
>       </capability>
>     </device>
> 
> The uuid will be autogenerated by libvirt and if there's no <group> (as
> is common for VMs with only 1 vGPU) it will be a single-device group.
> 

Right.

Kirti.

> Thanks,
> 
> Paolo
>