From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E10A7C4338F for ; Fri, 6 Aug 2021 04:17:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5700C60C3F for ; Fri, 6 Aug 2021 04:17:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5700C60C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBrIH-0004h4-8K for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 00:17:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBrGn-00032H-F6 for qemu-devel@nongnu.org; Fri, 06 Aug 2021 00:15:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBrGl-0006Mg-SJ for qemu-devel@nongnu.org; Fri, 06 Aug 2021 00:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628223339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjbzMrUNCRefHITRjeWegMmOKEhu/UpzfoIUepThUsk=; b=MFoaaivC1K1gnPsJ7T64441Tr8V3/tTVxU0ChbdCMqSOqfPk1jI9RMvhKJDW6ptKByDRU0 /sP/bjMDDl1MNxaCZi/dY5bdSdrfLM60fcXYR0Et/HPBW+5pKJAGcL9LWYaXG9ubfmAvwl bUvlhVXEO65fuu+psrrGlR/wu1Qvzgg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-vXK3yUFxOGqJGb95zmy_dQ-1; Fri, 06 Aug 2021 00:15:34 -0400 X-MC-Unique: vXK3yUFxOGqJGb95zmy_dQ-1 Received: by mail-wr1-f71.google.com with SMTP id r14-20020a5d4e4e0000b029015409d80a01so2697238wrt.12 for ; Thu, 05 Aug 2021 21:15:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AjbzMrUNCRefHITRjeWegMmOKEhu/UpzfoIUepThUsk=; b=Bx56EROIh30ZagAUNM0bf0lOemBezyOn3f56xgSwVi6RgtgXG/+3QkYo1vzZ16gUXc XR0TGnv/G3dLfdOpzbNhFLdHUPyTuxklhcJLxbPhsTB5Vfo5cATUmBK7YfkaDShPHI2a /u1eARqoKkOMQi0nDivWQXE46Pl9hCezhRRQFoJAW7kNYCp0vE/cC1nMcXJ7jKzOusmB IHZ6n6aXTY/pyOP0vTeKF9ZJa+TMSI1JaXmg5D07GEVI3v8juCBZw0/tJpBFEM6B2Oww MOGaY2dBcL5wPONL8hXUP/zDaT+H+9aj2SAxymMnGW/yjY89S2OWZNIRCHu4u2Z9bUcK q0BA== X-Gm-Message-State: AOAM5304s1erDAjYL1YSBCJesJquXeMwsAA1r6Z6A7jeane4tLOfqwde kLrm8SV+YUBapMtQCKAsPEPzdHAGVTwwF8vjXaDxHKdLGq0c+6Pcb6uNjmJ27EOo6KKdmDmEVt6 gl+GR9rstWf9m53k= X-Received: by 2002:adf:e3d2:: with SMTP id k18mr8425500wrm.212.1628223333651; Thu, 05 Aug 2021 21:15:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHNEREazUZE8lSUM2szD/xV1oyEEmw+mpH5HblqsYvzpSOxePhWLmqos732rFADn4d4Rb90A== X-Received: by 2002:adf:e3d2:: with SMTP id k18mr8425491wrm.212.1628223333487; Thu, 05 Aug 2021 21:15:33 -0700 (PDT) Received: from thuth.remote.csb (dynamic-046-114-147-107.46.114.pool.telefonica.de. [46.114.147.107]) by smtp.gmail.com with ESMTPSA id q124sm2852159wma.42.2021.08.05.21.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 21:15:33 -0700 (PDT) Subject: Re: [PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro To: Eduardo Habkost , qemu-devel@nongnu.org References: <20210805193431.307761-1-ehabkost@redhat.com> <20210805193431.307761-6-ehabkost@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 6 Aug 2021 06:15:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805193431.307761-6-ehabkost@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.132, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Cornelia Huck , Richard Henderson , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/08/2021 21.34, Eduardo Habkost wrote: > Use the SCLP_EVENT_BUS macro instead of manually calling > OBJECT_CHECK. > > Signed-off-by: Eduardo Habkost > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: qemu-s390x@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/s390x/event-facility.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c > index 9f7883d6e20..bc706bd19b4 100644 > --- a/hw/s390x/event-facility.c > +++ b/hw/s390x/event-facility.c > @@ -532,7 +532,7 @@ BusState *sclp_get_event_facility_bus(void) > SCLPEventsBus *sbus; > > busobj = object_resolve_path_type("", TYPE_SCLP_EVENTS_BUS, NULL); > - sbus = OBJECT_CHECK(SCLPEventsBus, busobj, TYPE_SCLP_EVENTS_BUS); > + sbus = SCLP_EVENT_BUS(busobj); > if (!sbus) { > return NULL; > } > I think this could be merged with the previous patch. Anyway: Reviewed-by: Thomas Huth