Re: [PATCH v8 2/4] cutils: Introduce bundle mechanism

[Thomas Huth <thuth@redhat.com>]

On 24/06/2022 16.50, Akihiko Odaki wrote:
> Developers often run QEMU without installing. The bundle mechanism
> allows to look up files which should be present in installation even in
> such a situation.
> 
> It is a general mechanism and can find any files in the installation
> tree. The build tree will have a new directory, qemu-bundle, to
> represent what files the installation tree would have for reference by
> the executables.
> 
> Note that it abandons compatibility with Windows older than 8. The
> extended support for the prior version, 7 ended more than 2 years ago,
> and it is unlikely that someone would like to run the latest QEMU on
> such an old system.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   docs/about/build-platforms.rst  |  2 +-
>   include/qemu/cutils.h           | 18 +++++++--
>   meson.build                     |  4 ++
>   scripts/symlink-install-tree.py | 37 ++++++++++++++++++
>   util/cutils.c                   | 68 +++++++++++++++++++++++----------
>   util/meson.build                |  1 +
>   6 files changed, 105 insertions(+), 25 deletions(-)
>   create mode 100755 scripts/symlink-install-tree.py
> 
> diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst
> index 1958edb4305..ebde20f9815 100644
> --- a/docs/about/build-platforms.rst
> +++ b/docs/about/build-platforms.rst
> @@ -88,7 +88,7 @@ Windows
>   
>   The project aims to support the two most recent versions of Windows that are
>   still supported by the vendor. The minimum Windows API that is currently
> -targeted is "Windows 7", so theoretically the QEMU binaries can still be run
> +targeted is "Windows 8", so theoretically the QEMU binaries can still be run
>   on older versions of Windows, too. However, such old versions of Windows are
>   not tested anymore, so it is recommended to use one of the latest versions of
>   Windows instead.

Please update _WIN32_WINNT in include/qemu/osdep.h accordingly.

Thanks,
  Thomas