From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93537C433DB for ; Tue, 9 Mar 2021 09:22:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0420A6522F for ; Tue, 9 Mar 2021 09:22:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0420A6522F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJYZT-0007SH-Tu for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 04:22:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJYYF-0006l3-IT for qemu-devel@nongnu.org; Tue, 09 Mar 2021 04:21:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJYYD-0000RD-Ir for qemu-devel@nongnu.org; Tue, 09 Mar 2021 04:21:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615281672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LcjxwZhX7BxwObbxSiK8mID2wAofrsc7dRBqfqbfsmA=; b=f91x/irFNHj4FSUQalZNfr9JXWLbcR+YwDVZPkQkRH1bCYXlOC4EOJBz09a+hRbggcbZOb BpFXLUEWPOyzD2ZQz2BcRKX4hgXTSKrQgJa6WHQrkKlZAuURyBf4Or/bVyQZXXb5JghEKB 3g8LByN+OKYlOLlN4e0Jy5AvMZNAAFM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-gIja-tdiN7ecBrKcFFmnUw-1; Tue, 09 Mar 2021 04:21:07 -0500 X-MC-Unique: gIja-tdiN7ecBrKcFFmnUw-1 Received: by mail-wr1-f72.google.com with SMTP id s10so6155081wre.0 for ; Tue, 09 Mar 2021 01:21:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LcjxwZhX7BxwObbxSiK8mID2wAofrsc7dRBqfqbfsmA=; b=EXU7xvsBJ8o9/WWxEIJmdIAEUvOUKCB05FA0BNlerVLt/Snxh6Mp4GRkd8Nb5GLaCn ModidoG3QyVs3d+8sWVHEc9pBPlDzE9ZKxE45UovrY/fsaZ/X4PFgXv5Acjd8egtTt8S JIYPrpxyR7iRX3VDnHq7sb/eYSnJG58g3m9/XXShaV7iC/bfva02T4leyYyUTjmq4Pd+ QTWg8ZtZpBxdRBNKNrd2quorkNhPRqn9ZA3oxBAFZcb2Qrd6vfxvfyB0vlv7C38lELZc SlktMZhGXhUWYFX8GNNOzp48XqkG2qtp2ZiUQAbEmNewUsdSRZON4TLKecPBe3UIKVSa E6kA== X-Gm-Message-State: AOAM530dA2jT4IG7CUhNrg39D5iAgkVskTMWFUtHrhlsanf52Nni+88Y LeT2N7/7Df67FvMgnz5EgHlDrkTqd+P2yxzqi+MFYXpYE5cUkj28jDi0q/cppHW/2dL6zxjgbSk iIR7UR2zclJLN92g= X-Received: by 2002:a1c:e18b:: with SMTP id y133mr2969709wmg.22.1615281666340; Tue, 09 Mar 2021 01:21:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxn+ytWc01Vf69K98PXu8752BSVdvopkiv1csE3OpPhjIKDI6HA6UIl3Nj85hJIEc2Ad6xu8A== X-Received: by 2002:a1c:e18b:: with SMTP id y133mr2969698wmg.22.1615281666133; Tue, 09 Mar 2021 01:21:06 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id f7sm2948067wmh.39.2021.03.09.01.21.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 01:21:05 -0800 (PST) Subject: Re: [RFC PATCH v2] meson: Only generate trace files for selected targets To: Claudio Fontana , Stefan Hajnoczi , Peter Maydell References: <20210224213515.3331631-1-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 9 Mar 2021 10:21:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/9/21 9:41 AM, Claudio Fontana wrote: > On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote: >> On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: >>> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: >>>> We don't need to generate trace files for targets we >>>> are not building. Restrict the the ones selected. >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> meson.build | 16 ++++++++-------- >>>> 1 file changed, 8 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/meson.build b/meson.build >>>> index 05a67c20d93..8503aa1b628 100644 >>>> --- a/meson.build >>>> +++ b/meson.build >>>> @@ -1826,16 +1826,16 @@ >>>> trace_events_subdirs += [ >>>> 'accel/tcg', >>>> 'hw/core', >>>> - 'target/arm', >>>> - 'target/hppa', >>>> - 'target/i386', >>>> 'target/i386/kvm', >>> >>> Please add a comment explaining why an exception is needed here and the >>> rest of the target directories are handled by the loop below when you >>> send a non-RFC patch. >> >> Better would be a recursive function that adds the directory if >> necessary. But I'm happy adding a simple comment =) >> >>> >>> That will help people who add sub-directories in the future. >> >> Yes. Anyhow I expect this to clash with Claudio's work in progress >> (which split target/ and add multiple subdirectories). >> >> > > np, just the tracedirs should be easy to solve; > > I personally don't see updating a simple list as difficult for the dev; does generating trace files for all require a lot of time? > > In any case, I agree that just recursing all directories in target/ looking for trace.h / traceevents files could be better. > > But how much time do we spare, compared with just generating all? Well now on slow 32-bit hosts my impression is we spend more time in meson / generating trace boilerplate files (even if the python code is trivial, it is invoked many times) rather than compiling C. trace doesn't use Kconfig to filter, so everything is processed. Maybe the root problem is 'hw/core' actually, not the 'target/' directories... This is more noticeable for the user-only builds, which are the ones likely to be supported longer on 32-bit hosts (there are some discussions about keeping maintaining sysemu there). That said this is user experience feeling and I didn't care to benchmark it. Anyhow this doesn't seem to have big impact (yet) so let's postpone this series. Thanks, Phil.