qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: qemu-ppc <qemu-ppc@nongnu.org>
Subject: hw/ppc/mac_newworld: Problem with Uninorth IRQ lines
Date: Tue, 21 Feb 2023 14:44:57 +0100	[thread overview]
Message-ID: <a728cf1f-49b5-ef09-cd68-57179a44438e@linaro.org> (raw)

Hi Mark,

The mac99 machines use the same PIC input IRQs for the Uninorth
output IRQs:

379     if (PPC_INPUT(env) != PPC_FLAGS_INPUT_970) {
380         /* Uninorth AGP bus */
381         for (i = 0; i < 4; i++) {
382             qdev_connect_gpio_out(uninorth_agp_dev, i,
383                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
384         }
385
386         /* Uninorth internal bus */
387         for (i = 0; i < 4; i++) {
388             qdev_connect_gpio_out(uninorth_internal_dev, i,
389                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
390         }
391     }

Did you mean to use an OR gate here?

Thanks,

Phil.


             reply	other threads:[~2023-02-21 13:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 13:44 Philippe Mathieu-Daudé [this message]
2023-02-21 15:17 ` hw/ppc/mac_newworld: Problem with Uninorth IRQ lines BALATON Zoltan
2023-03-01 12:24 ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a728cf1f-49b5-ef09-cd68-57179a44438e@linaro.org \
    --to=philmd@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).