hw/ppc/mac_newworld: Problem with Uninorth IRQ lines

hw/ppc/mac_newworld: Problem with Uninorth IRQ lines

[Philippe Mathieu-Daudé]

Hi Mark,

The mac99 machines use the same PIC input IRQs for the Uninorth
output IRQs:

379     if (PPC_INPUT(env) != PPC_FLAGS_INPUT_970) {
380         /* Uninorth AGP bus */
381         for (i = 0; i < 4; i++) {
382             qdev_connect_gpio_out(uninorth_agp_dev, i,
383                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
384         }
385
386         /* Uninorth internal bus */
387         for (i = 0; i < 4; i++) {
388             qdev_connect_gpio_out(uninorth_internal_dev, i,
389                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
390         }
391     }

Did you mean to use an OR gate here?

Thanks,

Phil.

Re: hw/ppc/mac_newworld: Problem with Uninorth IRQ lines

[BALATON Zoltan]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On Tue, 21 Feb 2023, Philippe Mathieu-Daudé wrote:
> The mac99 machines use the same PIC input IRQs for the Uninorth
> output IRQs:
>
> 379     if (PPC_INPUT(env) != PPC_FLAGS_INPUT_970) {
> 380         /* Uninorth AGP bus */
> 381         for (i = 0; i < 4; i++) {
> 382             qdev_connect_gpio_out(uninorth_agp_dev, i,
> 383                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
> 384         }
> 385
> 386         /* Uninorth internal bus */
> 387         for (i = 0; i < 4; i++) {
> 388             qdev_connect_gpio_out(uninorth_internal_dev, i,
> 389                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
> 390         }
> 391     }
>
> Did you mean to use an OR gate here?

This probably does not matter as these PCI busses are not used at all, 
they are just there to match real hardware but on QEMU everyting is 
connected to the 3rd PCI bus (which is actually the second numbered 
between the two others above, but OpenBIOS only knows about that PCI bus 
and does not care about the AGP and internal PCI buses so in practice 
these IRQs likely never raised so probably does not really matter where 
they are connected now).

Regards,
BALATON Zoltan

Re: hw/ppc/mac_newworld: Problem with Uninorth IRQ lines

[Mark Cave-Ayland]

On 21/02/2023 13:44, Philippe Mathieu-Daudé wrote:

> Hi Mark,
> 
> The mac99 machines use the same PIC input IRQs for the Uninorth
> output IRQs:
> 
> 379     if (PPC_INPUT(env) != PPC_FLAGS_INPUT_970) {
> 380         /* Uninorth AGP bus */
> 381         for (i = 0; i < 4; i++) {
> 382             qdev_connect_gpio_out(uninorth_agp_dev, i,
> 383                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
> 384         }
> 385
> 386         /* Uninorth internal bus */
> 387         for (i = 0; i < 4; i++) {
> 388             qdev_connect_gpio_out(uninorth_internal_dev, i,
> 389                                   qdev_get_gpio_in(pic_dev, 0x1b + i));
> 390         }
> 391     }
> 
> Did you mean to use an OR gate here?

Hi Phil,

These are separate PCI buses so I suspect they should be wired up with different 
IRQs, but this wiring has been the same ever since the code was introduced. I think 
it should be possible to dig the values out from a suitable device tree but it's not 
something I've looked at in any detail.


ATB,

Mark.