Re: [PATCH 2/2] migration: Unexport dirty_bitmap_mig_init() in misc.h

["Cédric Le Goater" <clg@redhat.com>]

On 10/22/24 18:07, Peter Xu wrote:
> It's only used within migration/, so it shouldn't be exported.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   include/migration/misc.h | 3 ---
>   migration/migration.h    | 4 ++++
>   2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/migration/misc.h b/include/migration/misc.h
> index 8d6812b8c7..e0e88b1c0c 100644
> --- a/include/migration/misc.h
> +++ b/include/migration/misc.h
> @@ -131,7 +131,4 @@ bool migration_incoming_postcopy_advised(void);
>   /* True if background snapshot is active */
>   bool migration_in_bg_snapshot(void);
>   
> -/* migration/block-dirty-bitmap.c */
> -void dirty_bitmap_mig_init(void);
> -
>   #endif
> diff --git a/migration/migration.h b/migration/migration.h
> index 7dc59c5e8d..0956e9274b 100644
> --- a/migration/migration.h
> +++ b/migration/migration.h
> @@ -552,4 +552,8 @@ int migration_rp_wait(MigrationState *s);
>   void migration_rp_kick(MigrationState *s);
>   
>   void migration_bitmap_sync_precopy(bool last_stage);
> +
> +/* migration/block-dirty-bitmap.c */
> +void dirty_bitmap_mig_init(void);
> +
>   #endif