From: Jason Wang <jasowang@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com,
jan.kiszka@siemens.com,
David Gibson <david@gibson.dropbear.id.au>,
alex.williamson@redhat.com, bd.aviv@gmail.com
Subject: Re: [Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling
Date: Tue, 7 Feb 2017 13:38:30 +0800 [thread overview]
Message-ID: <a743f890-9c55-1edc-e9a6-783bbd5a179b@redhat.com> (raw)
In-Reply-To: <1486110164-13797-8-git-send-email-peterx@redhat.com>
On 2017年02月03日 16:22, Peter Xu wrote:
> VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not
> good, and we should end the day when we need to recompile the code
> before getting useful debugging information for vt-d. Time to switch to
> the trace system.
Looks like we end up with using debug macros and tracepoints at the same
time (even with patch 8), this will cause even more troubles.
> This is the first patch to do it.
>
> Generally, the rule of mine is:
>
> - for the old GENERAL typed message, I use trace_vtd_err*() in general.
>
> - for the non-GENERAL typed messages, convert into specified trace_*().
>
> - for useless DPRINTFs, I removed them.
>
> Signed-off-by: Peter Xu<peterx@redhat.com>
> ---
The title is a little bit confusing, this in fact convert from debug
macros to tracepoints.
next prev parent reply other threads:[~2017-02-07 5:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 8:22 [Qemu-devel] [PATCH v6 00/18] VT-d: vfio enablement and misc enhances Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 01/18] vfio: trace map/unmap for notify as well Peter Xu
2017-02-06 1:27 ` David Gibson
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 02/18] vfio: introduce vfio_get_vaddr() Peter Xu
2017-02-03 17:20 ` Alex Williamson
2017-02-06 2:10 ` David Gibson
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 03/18] vfio: allow to notify unmap for very large region Peter Xu
2017-02-03 17:20 ` Alex Williamson
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 04/18] intel_iommu: add "caching-mode" option Peter Xu
2017-02-07 2:31 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 05/18] intel_iommu: simplify irq region translation Peter Xu
2017-02-07 5:23 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 06/18] intel_iommu: renaming gpa to iova where proper Peter Xu
2017-02-07 5:27 ` Jason Wang
2017-02-07 6:16 ` Peter Xu
2017-02-07 6:21 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling Peter Xu
2017-02-07 5:38 ` Jason Wang [this message]
2017-02-07 6:08 ` Peter Xu
2017-02-07 6:20 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 08/18] intel_iommu: fix trace for addr translation Peter Xu
2017-02-07 5:40 ` Jason Wang
2017-02-07 6:25 ` Peter Xu
2017-02-07 6:34 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 09/18] intel_iommu: vtd_slpt_level_shift check level Peter Xu
2017-02-07 5:42 ` Jason Wang
2017-02-07 8:03 ` Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 10/18] memory: add section range info for IOMMU notifier Peter Xu
2017-02-03 17:22 ` Alex Williamson
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 11/18] memory: provide IOMMU_NOTIFIER_FOREACH macro Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 12/18] memory: provide iommu_replay_all() Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 13/18] memory: introduce memory_region_notify_one() Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 14/18] memory: add MemoryRegionIOMMUOps.replay() callback Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 15/18] intel_iommu: provide its own replay() callback Peter Xu
2017-02-07 6:10 ` Jason Wang
2017-02-07 8:05 ` Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context invalidate Peter Xu
2017-02-07 6:16 ` Jason Wang
2017-02-07 8:12 ` Peter Xu
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 17/18] intel_iommu: allow dynamic switch of IOMMU region Peter Xu
2017-02-07 6:13 ` Jason Wang
2017-02-03 8:22 ` [Qemu-devel] [PATCH v6 18/18] intel_iommu: enable vfio devices Peter Xu
2017-02-07 6:19 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a743f890-9c55-1edc-e9a6-783bbd5a179b@redhat.com \
--to=jasowang@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=jan.kiszka@siemens.com \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).