From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRZyo-0006tA-He for qemu-devel@nongnu.org; Thu, 12 Jan 2017 02:39:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRZyl-0002S8-6B for qemu-devel@nongnu.org; Thu, 12 Jan 2017 02:39:26 -0500 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:35265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRZyl-0002Rt-0V for qemu-devel@nongnu.org; Thu, 12 Jan 2017 02:39:23 -0500 Received: by mail-oi0-x243.google.com with SMTP id x84so1707209oix.2 for ; Wed, 11 Jan 2017 23:39:22 -0800 (PST) References: <20170104144458.GC8194@stefanha-x1.localdomain> <20170112022212.GA26504@lemon> From: Yang Zhang Message-ID: Date: Thu, 12 Jan 2017 15:39:17 +0800 MIME-Version: 1.0 In-Reply-To: <20170112022212.GA26504@lemon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Stefan Hajnoczi , Eric Blake , Junkang Fu , qemu-devel@nongnu.org On 2017/1/12 10:22, Fam Zheng wrote: > On Thu, 01/12 09:22, Yang Zhang wrote: >> On 2017/1/4 22:44, Stefan Hajnoczi wrote: >>> On Tue, Jan 03, 2017 at 10:53:06AM -0600, Eric Blake wrote: >>>> On 12/29/2016 08:41 PM, Junkang Fu wrote: >>>>> >From 74e913fc41ea98d1dde692175f1e3fb6729342aa Mon Sep 17 00:00:00 2001 >>>>> From: "junkang.fjk" >>>>> Date: Wed, 24 Aug 2016 19:36:53 +0800 >>>>> Subject: [PATCH] virtio-blk: add disk-name device property >>>>> >>>>> Current virtio-blk disk name(ex. /dev/vdb) has nothing to do with the >>>>> target dev >>>>> name specified in libvirt xml file. For example, we may get disk name >>>>> /dev/vdb in >>>>> VM while target dev specified in libvirt xml is vdc. >>>> >>>> It's not really libvirt's fault. The libvirt XML names are for >>>> convenience, but nothing on the host side requires the guest to pick the >>>> same naming scheme as the host. >>>> >>>> I guess your proposal is to enhance the virtio spec such that clients >>>> that are new enough to honor the new addition to the virtio spec will >>>> change their name-picking algorithm to use the name provided by the >>>> host, rather than their current approach of picking whatever name they >>>> feel like, and then enhance libvirt to pass the XML name on down to the >>>> guest? It might work, but as others have pointed out, it will require a >>>> virtio spec change first. >>> >>> This change is unnecessary. The -device virtio-blk-pci,serial= property >>> already exists for this purpose. >> >> how about the /dev/vdabc? I guess lots of people prefer to use it instead of >> /dev/disk/by-id/xxx? > > I disagree. Using /dev/sdX has exactly the same issue and that's why fstab and > boot loader etc almost always use UUID or disk label by default because they are > more stable. I mean does it also change the /dev/sdX to the name specified in serial=sdX or it just show the name under /dev/disk/by-id/ -- Yang Alibaba Cloud Computing