[PATCH 0/2] tcg patch queue

[PATCH 0/2] tcg patch queue

[Richard Henderson]

The following changes since commit bc2e8b18fba33f30f25b7c2d74328493c0a2231d:

  Merge tag 'hppa64-pull-request' of https://github.com/hdeller/qemu-hppa into staging (2024-02-13 13:56:46 +0000)

are available in the Git repository at:

  https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240213

for you to fetch changes up to e41f1825b43796c3508ef309ed0b150ef89acc44:

  tcg/arm: Fix goto_tb for large translation blocks (2024-02-13 07:42:45 -1000)

----------------------------------------------------------------
tcg: Increase width of temp_subindex
tcg/arm: Fix goto_tb for large translation blocks

----------------------------------------------------------------
Richard Henderson (2):
      tcg: Increase width of temp_subindex
      tcg/arm: Fix goto_tb for large translation blocks

 include/tcg/tcg.h        | 2 +-
 tcg/arm/tcg-target.c.inc | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/2] tcg: Increase width of temp_subindex

[Richard Henderson]

We need values 0-3 for TCG_TYPE_I128 on 32-bit hosts.

Cc: qemu-stable@nongnu.org
Fixes: 43eef72f4109 ("tcg: Add temp allocation for TCGv_i128")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2159
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/tcg/tcg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
index daf2a5bf9e..451f3fec41 100644
--- a/include/tcg/tcg.h
+++ b/include/tcg/tcg.h
@@ -412,7 +412,7 @@ typedef struct TCGTemp {
     unsigned int mem_coherent:1;
     unsigned int mem_allocated:1;
     unsigned int temp_allocated:1;
-    unsigned int temp_subindex:1;
+    unsigned int temp_subindex:2;
 
     int64_t val;
     struct TCGTemp *mem_base;
-- 
2.34.1

[PATCH 2/2] tcg/arm: Fix goto_tb for large translation blocks

[Richard Henderson]

Correct arithmetic for separating high and low
on a large negative number.

Cc: qemu-stable@nongnu.org
Fixes: 79ffece4447 ("tcg/arm: Implement direct branch for goto_tb")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1714
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
---
 tcg/arm/tcg-target.c.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index ffd23ef789..6a04c73c76 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1771,9 +1771,9 @@ static void tcg_out_goto_tb(TCGContext *s, int which)
          * shifted immediate from pc.
          */
         int h = -i_disp;
-        int l = h & 0xfff;
+        int l = -(h & 0xfff);
 
-        h = encode_imm_nofail(h - l);
+        h = encode_imm_nofail(h + l);
         tcg_out_dat_imm(s, COND_AL, ARITH_SUB, TCG_REG_R0, TCG_REG_PC, h);
         tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_R0, l);
     }
-- 
2.34.1

[PULL 0/2] tcg patch queue

[Richard Henderson]

Dangit, PULL.

r~

On 2/13/24 15:25, Richard Henderson wrote:
> The following changes since commit bc2e8b18fba33f30f25b7c2d74328493c0a2231d:
> 
>    Merge tag 'hppa64-pull-request' of https://github.com/hdeller/qemu-hppa into staging (2024-02-13 13:56:46 +0000)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240213
> 
> for you to fetch changes up to e41f1825b43796c3508ef309ed0b150ef89acc44:
> 
>    tcg/arm: Fix goto_tb for large translation blocks (2024-02-13 07:42:45 -1000)
> 
> ----------------------------------------------------------------
> tcg: Increase width of temp_subindex
> tcg/arm: Fix goto_tb for large translation blocks
> 
> ----------------------------------------------------------------
> Richard Henderson (2):
>        tcg: Increase width of temp_subindex
>        tcg/arm: Fix goto_tb for large translation blocks
> 
>   include/tcg/tcg.h        | 2 +-
>   tcg/arm/tcg-target.c.inc | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 0/2] tcg patch queue

[Peter Maydell]

On Wed, 14 Feb 2024 at 01:26, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit bc2e8b18fba33f30f25b7c2d74328493c0a2231d:
>
>   Merge tag 'hppa64-pull-request' of https://github.com/hdeller/qemu-hppa into staging (2024-02-13 13:56:46 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240213
>
> for you to fetch changes up to e41f1825b43796c3508ef309ed0b150ef89acc44:
>
>   tcg/arm: Fix goto_tb for large translation blocks (2024-02-13 07:42:45 -1000)
>
> ----------------------------------------------------------------
> tcg: Increase width of temp_subindex
> tcg/arm: Fix goto_tb for large translation blocks
>
> ----------------------------------------------------------------
> Richard Henderson (2):
>       tcg: Increase width of temp_subindex
>       tcg/arm: Fix goto_tb for large translation blocks
>
>  include/tcg/tcg.h        | 2 +-
>  tcg/arm/tcg-target.c.inc | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.

-- PMM

[PULL 0/2] tcg patch queue

[Richard Henderson]

The following changes since commit 9fed1bca6bc643ce91b6117f4974421aaede4751:

  Merge tag 'pull-target-arm-20220711' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-11 22:02:09 +0530)

are available in the Git repository at:

  https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220712

for you to fetch changes up to b0f650f0477ae775e0915e3d60ab5110ad5e9157:

  accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore (2022-07-12 10:43:33 +0530)

----------------------------------------------------------------
Fix for duplicate tlb check on unaligned access.
Fix for w^x code gen buffer mapping.

----------------------------------------------------------------
Ilya Leoshkevich (1):
      accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore

Shaobo Song (1):
      tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()

 accel/tcg/cputlb.c | 8 +++++---
 tcg/region.c       | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Re: [PULL 0/2] tcg patch queue

[Richard Henderson]

On 7/12/22 11:50, Richard Henderson wrote:
> The following changes since commit 9fed1bca6bc643ce91b6117f4974421aaede4751:
> 
>    Merge tag 'pull-target-arm-20220711' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-11 22:02:09 +0530)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220712
> 
> for you to fetch changes up to b0f650f0477ae775e0915e3d60ab5110ad5e9157:
> 
>    accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore (2022-07-12 10:43:33 +0530)
> 
> ----------------------------------------------------------------
> Fix for duplicate tlb check on unaligned access.
> Fix for w^x code gen buffer mapping.

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.


r~


> 
> ----------------------------------------------------------------
> Ilya Leoshkevich (1):
>        accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore
> 
> Shaobo Song (1):
>        tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()
> 
>   accel/tcg/cputlb.c | 8 +++++---
>   tcg/region.c       | 2 +-
>   2 files changed, 6 insertions(+), 4 deletions(-)

[PULL 0/2] tcg patch queue

[Richard Henderson]

The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2020-07-04 16:08:41 +0100)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-tcg-20200706

for you to fetch changes up to 852f933e482518797f7785a2e017a215b88df815:

  tcg: Fix do_nonatomic_op_* vs signed operations (2020-07-06 10:58:19 -0700)

----------------------------------------------------------------
Fix for ppc shifts
Fix for non-parallel atomic ops

----------------------------------------------------------------
Catherine A. Frederick (1):
      tcg/ppc: Sanitize immediate shifts

Richard Henderson (1):
      tcg: Fix do_nonatomic_op_* vs signed operations

 tcg/ppc/tcg-target.inc.c | 15 ++++++++++-----
 tcg/tcg-op.c             | 10 ++++++----
 2 files changed, 16 insertions(+), 9 deletions(-)

Re: [PULL 0/2] tcg patch queue

[Peter Maydell]

On Mon, 6 Jul 2020 at 19:52, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2020-07-04 16:08:41 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-tcg-20200706
>
> for you to fetch changes up to 852f933e482518797f7785a2e017a215b88df815:
>
>   tcg: Fix do_nonatomic_op_* vs signed operations (2020-07-06 10:58:19 -0700)
>
> ----------------------------------------------------------------
> Fix for ppc shifts
> Fix for non-parallel atomic ops


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM