From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E23BC4332F for ; Wed, 12 Oct 2022 19:25:51 +0000 (UTC) Received: from localhost ([::1]:39728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oihMU-0001zB-7W for qemu-devel@archiver.kernel.org; Wed, 12 Oct 2022 15:25:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oihKD-0008UI-VQ for qemu-devel@nongnu.org; Wed, 12 Oct 2022 15:23:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:58101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oihKB-0002Nv-2X for qemu-devel@nongnu.org; Wed, 12 Oct 2022 15:23:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665602606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pcX9gtjnWe/gtt/k1zW1BcHUUgmbhTXz04U5cc9GZ44=; b=cSszwnho/FnDgbL5jrisY5dqiNAhc7vb5YKNo3+6ibAv6vjuH+4j3MWm6oY7yue6BvZoVF YCSAkKXFJHGW+2jM1ZKBFyhY6OND1OdUDTxP89q8tti9YDbJZLzdPN5sYVgElTMuSwOceJ aPZJfa+YzC2t9vylU/jneWfQ5T6Vttg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-85-16n5JTOLMoGxAjiukTjlaw-1; Wed, 12 Oct 2022 15:23:20 -0400 X-MC-Unique: 16n5JTOLMoGxAjiukTjlaw-1 Received: by mail-wr1-f70.google.com with SMTP id l16-20020adfc790000000b00230c2505f96so3075229wrg.4 for ; Wed, 12 Oct 2022 12:23:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pcX9gtjnWe/gtt/k1zW1BcHUUgmbhTXz04U5cc9GZ44=; b=KAUhGPzL31SOS6+FMgLKNHFRrNMolQeylG2irz1zNyVWLR/3aTClkFDM4uU6tK9/O0 aTRhMyJFttGWS/JFrk10YbYBlZuUGp9klzG0iBah1Oa606Wa6/TCWiUuRJaGauSTg6zb t+hpnyCXo8ZF/8CrUHc/C5vRg0/B9tmm21pDLzLsngpq4fFzLQotcPsNjEOiwp/rT9fq t9GQ/GLTmJhlitwycGhxYZ2GC+YFPsNflVlNdyEycI+XSRH00B34gk5U1aYcMuzV+hYm ifH+0G5W7sMxwmF5yngotQrSWVQ+yUshkeza/bRU0fdlafeheRpCr0QssOt5ssLQXNCI iUkA== X-Gm-Message-State: ACrzQf3j3hcieuvucnnO1qmr4zKXDCnPXcEf9EAsoLm4nNH4wdVY7jTh Cv3WFvHLSNsgVXLD4l8AqJbr7bJ9efnyWeKq0fiY9/keULgqHZWwyA+COICl26I5MVipmVhuyj7 GoT2u49Wqo/ko1kU= X-Received: by 2002:a05:600c:3b98:b0:3c6:c36e:a637 with SMTP id n24-20020a05600c3b9800b003c6c36ea637mr3815765wms.148.1665602599120; Wed, 12 Oct 2022 12:23:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7bJirtj2WQSNPnPaJDH2/nAXAw8tDPAdmQkfveJ4fVALHtIeoMst/Pe7SjCqVYOqAJavA0nQ== X-Received: by 2002:a05:600c:3b98:b0:3c6:c36e:a637 with SMTP id n24-20020a05600c3b9800b003c6c36ea637mr3815750wms.148.1665602598774; Wed, 12 Oct 2022 12:23:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:fd00:9f9b:c2f8:47fc:4836? (p200300cbc713fd009f9bc2f847fc4836.dip0.t-ipconnect.de. [2003:cb:c713:fd00:9f9b:c2f8:47fc:4836]) by smtp.gmail.com with ESMTPSA id t21-20020a1c7715000000b003b4de550e34sm2441986wmi.40.2022.10.12.12.23.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 12:23:18 -0700 (PDT) Message-ID: Date: Wed, 12 Oct 2022 21:23:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 1/3] tests/tcg/s390x: Test compiler flags only once, not every time Content-Language: en-US To: Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson Cc: qemu-devel@nongnu.org References: <20221012182755.1014853-1-thuth@redhat.com> <20221012182755.1014853-2-thuth@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221012182755.1014853-2-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.528, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12.10.22 20:27, Thomas Huth wrote: > This is common practice, see the Makefile.target in the aarch64 > folder for example. > > Suggested-by: Alex Bennée > Signed-off-by: Thomas Huth > --- > tests/tcg/s390x/Makefile.target | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target > index c830313e67..29c8af8207 100644 > --- a/tests/tcg/s390x/Makefile.target > +++ b/tests/tcg/s390x/Makefile.target > @@ -1,6 +1,13 @@ > S390X_SRC=$(SRC_PATH)/tests/tcg/s390x > VPATH+=$(S390X_SRC) > CFLAGS+=-march=zEC12 -m64 > + > +config-cc.mak: Makefile > + $(quiet-@)( \ > + $(call cc-option,-march=z14, CROSS_CC_HAS_Z14); \ > + $(call cc-option,-march=z15, CROSS_CC_HAS_Z15)) 3> config-cc.mak > +-include config-cc.mak > + > TESTS+=hello-s390x > TESTS+=csst > TESTS+=ipm > @@ -18,20 +25,20 @@ TESTS+=signals-s390x > TESTS+=branch-relative-long > TESTS+=noexec > > +ifneq ($(CROSS_CC_HAS_Z14),) > Z14_TESTS=vfminmax > vfminmax: LDFLAGS+=-lm > $(Z14_TESTS): CFLAGS+=-march=z14 -O2 > +TESTS+=$(Z14_TESTS) > +endif > > -TESTS+=$(if $(shell $(CC) -march=z14 -S -o /dev/null -xc /dev/null \ > - >/dev/null 2>&1 && echo OK),$(Z14_TESTS)) > - > -VECTOR_TESTS=vxeh2_vs > -VECTOR_TESTS+=vxeh2_vcvt > -VECTOR_TESTS+=vxeh2_vlstr > -$(VECTOR_TESTS): CFLAGS+=-march=z15 -O2 > - > -TESTS+=$(if $(shell $(CC) -march=z15 -S -o /dev/null -xc /dev/null \ > - >/dev/null 2>&1 && echo OK),$(VECTOR_TESTS)) > +ifneq ($(CROSS_CC_HAS_Z15),) > +Z15_TESTS=vxeh2_vs > +Z15_TESTS+=vxeh2_vcvt > +Z15_TESTS+=vxeh2_vlstr > +$(Z15_TESTS): CFLAGS+=-march=z15 -O2 > +TESTS+=$(Z15_TESTS) > +endif > > ifneq ($(HAVE_GDB_BIN),) > GDB_SCRIPT=$(SRC_PATH)/tests/guest-debug/run-test.py Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb