From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 806E4C433F5 for ; Sat, 9 Apr 2022 20:52:17 +0000 (UTC) Received: from localhost ([::1]:52356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndI48-0000ho-KQ for qemu-devel@archiver.kernel.org; Sat, 09 Apr 2022 16:52:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndI2X-0008Aa-P0 for qemu-devel@nongnu.org; Sat, 09 Apr 2022 16:50:39 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:36656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndI2V-0005cp-3k for qemu-devel@nongnu.org; Sat, 09 Apr 2022 16:50:36 -0400 Received: by mail-pl1-x62e.google.com with SMTP id m16so10828374plx.3 for ; Sat, 09 Apr 2022 13:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VNpuLewJ4Bg0eOowEp5pClkJz2gT29vLZ7tOoLyNSg0=; b=Hlvx0iNbNLySRtV/nXdEVoiX22mDVc6Mfyyf66GK1TscQ62QRVzqVMQWQMfCzWtiZK NERk0qm0NkZvC16nQAAGE6PI4LLk7uk1t4wdtpmjPNtAbUEqKZ2ki+2GTdxNsHCjibCZ OFqjSAkw5pzdrAigEUl8nyQPUVYQme17b8ui52wQC676pCA9+NTZSznO+1xxZCasCbYE rcOdz4wmafB25eKRWyCZ/FjBYgTHwMWMcA91w+1+veoh8opatmdRy33NJvK/sheyMo/T v/IiDDnsNb+y19ZZ2ipbANzMHaZVoLw96nzrIg1LoCeTl8RUUUPk4Hz64H/N7GZnBsHw WK1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VNpuLewJ4Bg0eOowEp5pClkJz2gT29vLZ7tOoLyNSg0=; b=TZUHL3I+QPKsIi2cg7i4mFki7F4jNGhbfuSxThjkDRQr0wyG6mGQ89klCut2LSZRIZ Fo4jg3DYknzzefjcUgubehv0GQqTtygM4Ic/OLCnv+ovo8rjKqhcVCoYYLGZ79xkZYki Ab571HVl3KbpCKRuYhxHreWJeWzwqwuoCmzpqEhSZSLx9QnJ342c1pG5gZ1V1X6aPjYw PiU4/j09iNBHHrizX34tPKc2FBYG2yiQF+Y018enCmLFWKiOG1oSJxtkAJQobn63c6+M gXZFrIOQiP+A8mO7C4IKap/Z6I1l1tvkUOT2USLzHF/5WjGOPzp9+V8ILxTjBBPhcMRh ujgw== X-Gm-Message-State: AOAM5333sP55NK38Jrm67D/UWJ9tbewEyo0f5mIkeKKs84lOYfWjkoe6 rgHtUSaE6qngo6Wbk/X9CAD+Tw== X-Google-Smtp-Source: ABdhPJwESzdmxDJREdkfU5IXvITeV2GtwTXgujk7iLq1NXP4P6IN5mw6xDlgZ0i/+potmMePPZmkCg== X-Received: by 2002:a17:90b:3b50:b0:1c7:5d55:3cb8 with SMTP id ot16-20020a17090b3b5000b001c75d553cb8mr28723659pjb.78.1649537433735; Sat, 09 Apr 2022 13:50:33 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id 75-20020a62174e000000b0050579f94ed2sm6724853pfx.96.2022.04.09.13.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 13:50:33 -0700 (PDT) Message-ID: Date: Sat, 9 Apr 2022 13:50:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 38/41] hw/intc/arm_gicv3: Allow 'revision' property to be set to 4 Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220408141550.1271295-1-peter.maydell@linaro.org> <20220408141550.1271295-39-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20220408141550.1271295-39-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/8/22 07:15, Peter Maydell wrote: > Now that we have implemented all the GICv4 requirements, relax the > error-checking on the GIC object's 'revision' property to allow a TCG > GIC to be a GICv4, whilst still constraining the KVM GIC to GICv3. > > Our 'revision' property doesn't consider the possibility of wanting > to specify the minor version of the GIC -- for instance there is a > GICv3.1 which adds support for extended SPI and PPI ranges, among > other things, and also GICv4.1. But since the QOM property is > internal to QEMU, not user-facing, we can cross that bridge when we > come to it. Within the GIC implementation itself code generally > checks against the appropriate ID register feature bits, and the > only use of s->revision is for setting those ID register bits. > > Signed-off-by: Peter Maydell > --- > hw/intc/arm_gicv3_common.c | 12 +++++++----- > hw/intc/arm_gicv3_kvm.c | 5 +++++ > 2 files changed, 12 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~