From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boVAv-0003zn-1L for qemu-devel@nongnu.org; Mon, 26 Sep 2016 08:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boVAo-0005q4-Uu for qemu-devel@nongnu.org; Mon, 26 Sep 2016 08:38:23 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:33945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boVAo-0005p8-OL for qemu-devel@nongnu.org; Mon, 26 Sep 2016 08:38:18 -0400 References: <00a3b0f8e865f9b04e813e63e4c9d4a6d98da210.1474886798.git.sagark@eecs.berkeley.edu> <4606a059-a1be-62ab-d3eb-c432f1be4c6c@redhat.com> From: Bastian Koppelmann Message-ID: Date: Mon, 26 Sep 2016 14:38:13 +0200 MIME-Version: 1.0 In-Reply-To: <4606a059-a1be-62ab-d3eb-c432f1be4c6c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/18] target-riscv: Add system instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Sagar Karandikar , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net On 09/26/2016 02:21 PM, Paolo Bonzini wrote: > > > On 26/09/2016 12:56, Sagar Karandikar wrote: >> +#ifndef CONFIG_USER_ONLY >> +DEF_HELPER_4(csrrw, tl, env, tl, tl, tl) >> +DEF_HELPER_5(csrrs, tl, env, tl, tl, tl, tl) >> +DEF_HELPER_5(csrrc, tl, env, tl, tl, tl, tl) >> +DEF_HELPER_2(sret, tl, env, tl) >> +DEF_HELPER_2(mret, tl, env, tl) >> +DEF_HELPER_1(tlb_flush, void, env) >> +DEF_HELPER_1(fence_i, void, env) >> +#endif /* !CONFIG_USER_ONLY */ > > The system emulation spec is still in flux, I think we should only add > user-mode emulation for now. > Hi Paolo, by user-mode emulation you still mean softmmu and not linux-user, right? So just drop the system instructions for now. Cheers, Bastian