qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6 3/3] migration: Make dirty_bytes_last_sync atomic
Date: Thu, 27 Apr 2023 11:09:50 +0100	[thread overview]
Message-ID: <a79adcbf-3efb-2421-5e39-fecbb97381ac@linaro.org> (raw)
In-Reply-To: <20230427095250.22350-4-quintela@redhat.com>

On 4/27/23 10:52, Juan Quintela wrote:
> As we set its value, it needs to be operated with atomics.
> We rename it from remaining to better reflect its meaning.
> 
> Statistics always return the real reamaining bytes.  This was used to
> store how much pages where dirty on the previous generation, so we can
> calculate the expected downtime as: dirty_bytes_last_sync /
> current_bandwith.
> 
> If we use the actual remaining bytes, we would see a very small value
> at the end of the iteration.
> 
> Signed-off-by: Juan Quintela<quintela@redhat.com>
> Reviewed-by: Peter Xu<peterx@redhat.com>
> 
> ---
> 
> I am open to use ram_bytes_remaining() in its only use and be more
> "optimistic" about the downtime.
> 
> Don't use __nocheck() functions.
> Use stat64_get() now that it exists.
> ---
>   migration/migration.c | 3 ++-
>   migration/ram.c       | 2 +-
>   migration/ram.h       | 2 +-
>   3 files changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2023-04-27 10:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  9:52 [PATCH v6 0/3] Migration: Make more ram_counters atomic Juan Quintela
2023-04-27  9:52 ` [PATCH v6 1/3] stat64: Add stat64_set() operation Juan Quintela
2023-04-27 10:08   ` Richard Henderson
2023-04-27  9:52 ` [PATCH v6 2/3] migration: Make dirty_pages_rate atomic Juan Quintela
2023-04-27 10:08   ` Richard Henderson
2023-04-27  9:52 ` [PATCH v6 3/3] migration: Make dirty_bytes_last_sync atomic Juan Quintela
2023-04-27 10:09   ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a79adcbf-3efb-2421-5e39-fecbb97381ac@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=leobras@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).