Re: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Tue, 2025-01-21 at 15:04 +0800, Jamin Lin wrote:
> The design of the INTC has significant changes in the AST2700 A1. In
> the
> AST2700 A0, there was one INTC controller, whereas in the AST2700 A1,
> there were two INTC controllers: INTC0 (CPU DIE) and INTC1 (I/O DIE).
> 
> The previous INTC model only supported the AST2700 A0 and was
> implemented for
> the INTC0 (CPU DIE). To support the future INTC1 (I/O DIE) model,
> rename INTC
> to INTC0.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>  hw/arm/aspeed_ast27x0.c       |  6 +--
>  hw/intc/aspeed_intc.c         | 90 +++++++++++++++++----------------
> --
>  include/hw/arm/aspeed_soc.h   |  2 +-
>  include/hw/intc/aspeed_intc.h |  2 +-
>  4 files changed, 50 insertions(+), 50 deletions(-)
> 
> diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
> index 4114e15ddd..ba461fcd3c 100644
> --- a/hw/arm/aspeed_ast27x0.c
> +++ b/hw/arm/aspeed_ast27x0.c
> @@ -56,7 +56,7 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
>      [ASPEED_DEV_ETH2]      =  0x14060000,
>      [ASPEED_DEV_ETH3]      =  0x14070000,
>      [ASPEED_DEV_EMMC]      =  0x12090000,
> -    [ASPEED_DEV_INTC]      =  0x12100000,
> +    [ASPEED_DEV_INTC0]     =  0x12100000,
>      [ASPEED_DEV_SLI]       =  0x12C17000,
>      [ASPEED_DEV_SLIIO]     =  0x14C1E000,
>      [ASPEED_GIC_DIST]      =  0x12200000,
> @@ -372,7 +372,7 @@ static void aspeed_soc_ast2700_init(Object *obj)
>  
>      object_initialize_child(obj, "sli", &s->sli,
> TYPE_ASPEED_2700_SLI);
>      object_initialize_child(obj, "sliio", &s->sliio,
> TYPE_ASPEED_2700_SLIIO);
> -    object_initialize_child(obj, "intc", &a->intc,
> TYPE_ASPEED_2700_INTC);
> +    object_initialize_child(obj, "intc", &a->intc,
> TYPE_ASPEED_2700_INTC0);

Shouldn't we also change the propname to "intc0" (... if we're to
continue with that style of naming)?

Andrew