From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB63CC7618F for ; Mon, 15 Jul 2019 13:50:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7DB120651 for ; Mon, 15 Jul 2019 13:50:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7DB120651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn1NA-0005mL-11 for qemu-devel@archiver.kernel.org; Mon, 15 Jul 2019 09:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53543) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn1Mw-00056p-MW for qemu-devel@nongnu.org; Mon, 15 Jul 2019 09:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn1Mv-0002P2-85 for qemu-devel@nongnu.org; Mon, 15 Jul 2019 09:50:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39284) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hn1Ms-0002N7-GK; Mon, 15 Jul 2019 09:50:14 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 369263082DDD; Mon, 15 Jul 2019 13:50:13 +0000 (UTC) Received: from thuth.remote.csb (reserved-198-198.str.redhat.com [10.33.198.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DB645DAA4; Mon, 15 Jul 2019 13:49:55 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Cornelia Huck References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> <20190715130955.4a117388.cohuck@redhat.com> <13fce62f-234c-1b13-595f-5910c066bc4f@redhat.com> <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: Date: Mon, 15 Jul 2019 15:49:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 15 Jul 2019 13:50:13 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Collin Walling , "open list:RISC-V" , Eduardo Habkost , Sagar Karandikar , "Michael S. Tsirkin" , Helge Deller , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Aurelien Jarno , "open list:S390" , qemu-arm , Alistair Francis , Gerd Hoffmann , Paolo Bonzini , qemu-ppc , Richard Henderson , Artyom Tarasenko , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/07/2019 15.38, Philippe Mathieu-Daud=C3=A9 wrote: > On 7/15/19 3:19 PM, Thomas Huth wrote: >> On 15/07/2019 13.09, Cornelia Huck wrote: >>> On Mon, 15 Jul 2019 13:04:28 +0200 >>> Philippe Mathieu-Daud=C3=A9 wrote: >>> >>>> On 7/15/19 12:56 PM, Cornelia Huck wrote: >>>>> On Mon, 15 Jul 2019 12:48:55 +0200 >>>>> Thomas Huth wrote: >>>>> =20 >>>>>> On 15/07/2019 12.19, Peter Maydell wrote: =20 >>>>>>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrot= e: =20 >>>>>>>> >>>>>>>> On 15/07/2019 11.55, Philippe Mathieu-Daud=C3=A9 wrote: =20 >>>>>>>>> If a controller device provides a PCI bus, we can plug any PCI >>>>>>>>> daughter card on it. >>>>>>>>> >>>>>>>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>>>>>>>> --- =20 >>>>>>> =20 >>>>>>>>> diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig >>>>>>>>> index 77f8b005ff..0f7267db35 100644 >>>>>>>>> --- a/hw/pci/Kconfig >>>>>>>>> +++ b/hw/pci/Kconfig >>>>>>>>> @@ -1,5 +1,6 @@ >>>>>>>>> config PCI >>>>>>>>> bool >>>>>>>>> + imply PCI_DEVICES =20 >>>>>>>> >>>>>>>> No, please don't change this. This was done on purpose, since al= most all >>>>>>>> PCI_DEVICES do not work on s390x (so s390x does *not* imply PCI_= DEVICES). =20 >>>>>>> >>>>>>> But that means that every board that provides PCI has to have an >>>>>>> "imply PCI_DEVICES" line, which is pretty clunky just to work >>>>>>> around an s390x limitation. >>>>>>> >>>>>>> Is there some way in the Kconfig syntax for s390x to say >>>>>>> "no PCI_DEVICES" so we can have the corner-case be handled >>>>>>> by the s390x Kconfig in one place rather than in 20 places >>>>>>> affecting everywhere except s390x? =20 >>>>>> >>>>>> IIRC the problem on s390x are the legacy IRQs. s390x has only MSIs= . So I >>>>>> guess the correct way to fix this would be to introduce some >>>>>> PCI_LEGACY_IRQ switch and let all old devices that do not work wit= h MSI >>>>>> depend on it. =20 >>>>> >>>>> s/MSI/MSI-X/, IIRC. Not sure how far 'legacy' would stretch. =20 >>>> >>>> Maybe we can have something like PCI_LEGACY_DEVICES and PCI_MSI_DEVI= CES? >>>> >>>> So if s390x only selects PCI_LEGACY (not PCI_MSI) bus, then it only = get >>>> legacy devices? >>> >>> Wrong way around? We need MSI-X for s390x, not plain MSI or >>> 'legacy' (whatever that is). >> >> With "legacy" I meant the old level-triggered interrupts from the earl= y >> PCI (non-express) days. Sorry for being imprecise here. >> >> So maybe we need two new switches, PCI_CLASSIC (or so) and PCI_MSIX, a= nd >> then the PCI devices should be marked with "default y if PCI_CLASSIC" = if >> they do not have MSIX support, and with "default y if PCI_MSIX" if the= y >> have MSI-X support? >=20 > Something like that :) >=20 > Per Wikipedia: >=20 > Conventional PCI and PCI-X are sometimes called Parallel PCI > in order to distinguish them technologically from their more > recent successor PCI Express, which adopted a serial, > lane-based architecture. >=20 > The PCI-SIG introduced the serial PCI Express in c.=E2=80=892004. At > the same time, they renamed PCI as Conventional PCI. >=20 > PCI Express does not have physical interrupt lines at all. > It uses message-signaled interrupts exclusively. >=20 > What about PCI_CONVENTIONAL then? Sounds good to me. Thomas