From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] exec.c: Replace memory_region_is_unassigned() with memory_region_is_ram_backed()
Date: Mon, 9 Jul 2018 10:50:51 -0700 [thread overview]
Message-ID: <a7caddb3-038e-a97c-26db-13a7ad05576e@twiddle.net> (raw)
In-Reply-To: <CAFEAcA9g3NCcodB8H3m5MsCL=JD56HO6D-utLyUKvY_Nwv-0Jg@mail.gmail.com>
On 07/09/2018 10:33 AM, Peter Maydell wrote:
>> Well... ok. We should document that this, surprisingly, does not include
>> actual ram. Just things that are ram with caveats.
>
> I think it must include actual RAM, or we would not be able to
> execute from actual RAM ? The only way to get to get_page_addr_code()'s
> "here's the ram_addr_t for this" exit path is if memory_region_is_unassigned()
> returns false.
>
>>> - return mr != &io_mem_rom && mr != &io_mem_notdirty && !mr->rom_device
>>> - && mr != &io_mem_watch;
Huh. I don't follow how this old expression excludes ram,
and so assumed that must be checked separately earlier.
There's clearly still something here I don't understand.
r~
next prev parent reply other threads:[~2018-07-09 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:58 [Qemu-devel] [PATCH] exec.c: Replace memory_region_is_unassigned() with memory_region_is_ram_backed() Peter Maydell
2018-07-09 17:23 ` Richard Henderson
2018-07-09 17:33 ` Peter Maydell
2018-07-09 17:50 ` Richard Henderson [this message]
2018-07-10 10:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7caddb3-038e-a97c-26db-13a7ad05576e@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).