From: "Denis V. Lunev" <den@openvz.org>
To: Eric Blake <eblake@redhat.com>,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "fam@euphon.net" <fam@euphon.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/io.c: fix for the allocation failure
Date: Mon, 19 Aug 2019 19:46:33 +0000 [thread overview]
Message-ID: <a7cfd04b-5185-e13c-2ced-7e689de05247@openvz.org> (raw)
In-Reply-To: <5dc0231e-6fbc-3efc-8cc7-ff953651d0e9@redhat.com>
On 8/17/19 5:56 PM, Eric Blake wrote:
> On 8/17/19 9:49 AM, Eric Blake wrote:
>
>>> This change is a regression of sorts. Now, you are unconditionally
>>> attempting the fallback for ALL failures (such as EIO) and for all
>>> drivers, even when that was not previously attempted and increases the
>>> traffic. I think we should revert this patch and instead fix the
>>> fallocate() path to convert whatever ACTUAL errno you got from unaligned
>>> fallocate failure into ENOTSUP (that is, just the file-posix.c location
>>> that failed), while leaving all other errors as immediately fatal.
> Or even better, fix the call site of fallocate() to skip attempting an
> unaligned fallocate(), and just directly return ENOTSUP, rather than
> trying to diagnose EINVAL after the fact.
>
No way. Single ENOTSUP will turn off fallocate() support on caller side
while
aligned (99.99% of calls) works normally.
Den
next prev parent reply other threads:[~2019-08-19 19:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 14:24 [Qemu-devel] [PATCH] block/io.c: fix for the allocation failure Andrey Shinkevich
2019-04-05 14:24 ` Andrey Shinkevich
2019-04-05 22:50 ` [Qemu-devel] [Qemu-block] " John Snow
2019-04-05 22:50 ` John Snow
2019-04-08 9:44 ` Andrey Shinkevich
2019-04-08 9:44 ` Andrey Shinkevich
2019-04-08 10:04 ` Kevin Wolf
2019-04-08 10:04 ` Kevin Wolf
2019-04-08 10:14 ` Kevin Wolf
2019-04-08 10:14 ` Kevin Wolf
2019-04-10 14:54 ` Stefan Hajnoczi
2019-04-10 14:54 ` Stefan Hajnoczi
2019-04-08 11:55 ` Andrey Shinkevich
2019-04-08 11:55 ` Andrey Shinkevich
2019-04-08 9:00 ` [Qemu-devel] " Stefan Hajnoczi
2019-04-08 9:00 ` Stefan Hajnoczi
2019-04-08 9:45 ` Andrey Shinkevich
2019-04-08 9:45 ` Andrey Shinkevich
2019-08-17 14:42 ` Eric Blake
2019-08-17 14:49 ` Eric Blake
2019-08-17 14:56 ` Eric Blake
2019-08-19 19:46 ` Denis V. Lunev [this message]
2019-08-19 20:30 ` Eric Blake
2019-08-19 20:53 ` Denis V. Lunev
2019-08-19 21:29 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7cfd04b-5185-e13c-2ced-7e689de05247@openvz.org \
--to=den@openvz.org \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).