Re: [PATCH 13/16] accel/tcg: Build tcg-accel-ops-mttcg.c once

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 3/7/25 10:56, Richard Henderson wrote:
> All that is required is to avoid including exec-all.h.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   accel/tcg/tcg-accel-ops-mttcg.c | 1 -
>   accel/tcg/meson.build           | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c
> index ba7cf6819d..bdcc385ae9 100644
> --- a/accel/tcg/tcg-accel-ops-mttcg.c
> +++ b/accel/tcg/tcg-accel-ops-mttcg.c
> @@ -30,7 +30,6 @@
>   #include "qemu/main-loop.h"
>   #include "qemu/notify.h"
>   #include "qemu/guest-random.h"
> -#include "exec/exec-all.h"
>   #include "hw/boards.h"
>   #include "tcg/startup.h"
>   #include "tcg-accel-ops.h"
> diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
> index 87c1394b62..81fb25da5c 100644
> --- a/accel/tcg/meson.build
> +++ b/accel/tcg/meson.build
> @@ -20,7 +20,6 @@ specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_specific_ss)
>   
>   specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files(
>     'cputlb.c',
> -  'tcg-accel-ops-mttcg.c',
>   ))
>   
>   system_ss.add(when: ['CONFIG_TCG'], if_true: files(
> @@ -28,6 +27,7 @@ system_ss.add(when: ['CONFIG_TCG'], if_true: files(
>     'monitor.c',
>     'tcg-accel-ops.c',
>     'tcg-accel-ops-icount.c',
> +  'tcg-accel-ops-mttcg.c',
>     'tcg-accel-ops-rr.c',
>     'watchpoint.c',
>   ))

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>