From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [PATCH 0/4] target/s390x: CC fixes
Date: Tue, 31 Oct 2023 09:38:36 +0100 [thread overview]
Message-ID: <a7d962b5-d9d2-41f6-9f28-b84490cad0f8@redhat.com> (raw)
In-Reply-To: <20231031053718.347100-1-iii@linux.ibm.com>
On 31.10.23 06:32, Ilya Leoshkevich wrote:
> Hi,
>
> This series fixes two issues with updating CC. David was suggesting a
> bigger rewrite [1], but I did not dare do this (yet). Instead, these
I started coding that up but was distracted by other things; last time I
looked at that, I concluded that the way we are calculating the carry in
not suitable when we're doing two additions (like ADD LOGICAL WITH CARRY).
In addition, the way cout_addu32/cout_addu64 relies on cc_src/cc_dst is
wrong in some occurrences.
> are targeted fixes: patch 1 helps with installing Fedora, and patch 3
> addresses something I noticed when reviewing the code. Patches 2 and 4
> are tests.
I assume you are only scratching the surface with your fixes and we
might be better off just doing CC_OP_ADDU / CC_OP_SUBU like CC_OP_ADD_32
/ CC_OP_ADD_64 / ... to fix all issues involved.
>
> Best regards,
> Ilya
>
> [1] https://gitlab.com/qemu-project/qemu/-/issues/1865#note_1545060658
>
> Ilya Leoshkevich (4):
> target/s390x: Fix CLC corrupting cc_src
> tests/tcg/s390x: Test CLC with inaccessible second operand
> target/s390x: Fix LAALG not updating cc_src
> tests/tcg/s390x: Test LAALG with negative cc_src
>
> target/s390x/tcg/translate.c | 10 ++++---
> tests/tcg/s390x/Makefile.target | 2 ++
> tests/tcg/s390x/clc.c | 48 +++++++++++++++++++++++++++++++++
> tests/tcg/s390x/laalg.c | 27 +++++++++++++++++++
> 4 files changed, 84 insertions(+), 3 deletions(-)
> create mode 100644 tests/tcg/s390x/clc.c
> create mode 100644 tests/tcg/s390x/laalg.c
>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-10-31 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 5:32 [PATCH 0/4] target/s390x: CC fixes Ilya Leoshkevich
2023-10-31 5:32 ` [PATCH 1/4] target/s390x: Fix CLC corrupting cc_src Ilya Leoshkevich
2023-10-31 22:49 ` Richard Henderson
2023-10-31 5:32 ` [PATCH 2/4] tests/tcg/s390x: Test CLC with inaccessible second operand Ilya Leoshkevich
2023-10-31 22:53 ` Richard Henderson
2023-11-06 9:20 ` Ilya Leoshkevich
2023-10-31 5:32 ` [PATCH 3/4] target/s390x: Fix LAALG not updating cc_src Ilya Leoshkevich
2023-10-31 22:57 ` Richard Henderson
2023-10-31 5:32 ` [PATCH 4/4] tests/tcg/s390x: Test LAALG with negative cc_src Ilya Leoshkevich
2023-10-31 8:38 ` David Hildenbrand [this message]
2023-11-03 16:44 ` [PATCH 0/4] target/s390x: CC fixes Ilya Leoshkevich
2023-11-03 17:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7d962b5-d9d2-41f6-9f28-b84490cad0f8@redhat.com \
--to=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).