From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B96C4332F for ; Tue, 31 Oct 2023 08:39:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxkGu-0002N3-5N; Tue, 31 Oct 2023 04:38:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxkGs-0002MT-1l for qemu-devel@nongnu.org; Tue, 31 Oct 2023 04:38:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxkGq-00025s-CE for qemu-devel@nongnu.org; Tue, 31 Oct 2023 04:38:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698741523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=l3vaF/rON/IGAnk2ClkbvWv7eLZSHH3EJlYGfm8PYLE=; b=AQzCOdHChRnkL5avlo6+COEgfcx8cSOirCRiUnBuANKH3KHoeHH19QAYncy/ZTklPHaLsX w8MAPhUM8lx2mGym5q+f+C5T0WUQqXUxXAOVoyBLbGdXvOvQhWRLi7DOVrBHnbrtRhjVPd AcOiFYJTXsboCkLmL2Z0mtu5kdosj2U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-IK4CbsyqPTS2j21YWZg6gA-1; Tue, 31 Oct 2023 04:38:40 -0400 X-MC-Unique: IK4CbsyqPTS2j21YWZg6gA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32dc767e619so2773404f8f.1 for ; Tue, 31 Oct 2023 01:38:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698741518; x=1699346318; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l3vaF/rON/IGAnk2ClkbvWv7eLZSHH3EJlYGfm8PYLE=; b=IUOiRGkHj3h/80xjN0w7A+isJSIEK1ryDHzeeZm68G7rb9m2JzhxR/lwvOi3d/5u2e C88sQAe6A1qUwAxU4qvnPfTGYjVWuVvcLXOtr7EtCEW5bm7UP5JYGLlT1gyFlHdaZoCt wmIag+nMHXgVZEckULdkqTkBdIMwfohj0Eel0UsqwbNrgXtURMEWBde2gKvdHOY6rw24 eo3zRNhPFHKG9rC7VljhzjITpHD8qYro1xIxdkAqcoUf17BwI6hSdieNPTeRIfjk4Mkp heQDCZAH0qeHxRT3tHedJmoqGb1+JVMNe5N7QtHszPRWSGpTGlKOzveASsWjsuDFXifm XNoA== X-Gm-Message-State: AOJu0YxRRvHTk3JzWSHKVcZIHuntPz1b8WLihb+4s3Xu2PtidP7v1o3k pJZoDlYHFUac1TUAjbL/gOUT+SIGnHuOLX+vfnr9yK0laZ1xP4xDTaUxAI02imQluvgiHgbBFc3 oB6aMnekrlFao34g= X-Received: by 2002:a5d:6410:0:b0:32d:9a1b:5d7f with SMTP id z16-20020a5d6410000000b0032d9a1b5d7fmr8474423wru.29.1698741518582; Tue, 31 Oct 2023 01:38:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOpSgUaNnXKJ0dZmIrqWnE3CE7ksIrWFQyVgT9Dd1pgDE01NZ9EGEn1K7bH1qc9ITnW0j4GA== X-Received: by 2002:a5d:6410:0:b0:32d:9a1b:5d7f with SMTP id z16-20020a5d6410000000b0032d9a1b5d7fmr8474405wru.29.1698741518170; Tue, 31 Oct 2023 01:38:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:8f00:43b0:1107:57d2:28ee? (p200300cbc7078f0043b0110757d228ee.dip0.t-ipconnect.de. [2003:cb:c707:8f00:43b0:1107:57d2:28ee]) by smtp.gmail.com with ESMTPSA id m5-20020adfe945000000b0032f7cc56509sm923343wrn.98.2023.10.31.01.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 01:38:37 -0700 (PDT) Message-ID: Date: Tue, 31 Oct 2023 09:38:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] target/s390x: CC fixes To: Ilya Leoshkevich , Richard Henderson Cc: Thomas Huth , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Michael Tokarev References: <20231031053718.347100-1-iii@linux.ibm.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231031053718.347100-1-iii@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.483, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 31.10.23 06:32, Ilya Leoshkevich wrote: > Hi, > > This series fixes two issues with updating CC. David was suggesting a > bigger rewrite [1], but I did not dare do this (yet). Instead, these I started coding that up but was distracted by other things; last time I looked at that, I concluded that the way we are calculating the carry in not suitable when we're doing two additions (like ADD LOGICAL WITH CARRY). In addition, the way cout_addu32/cout_addu64 relies on cc_src/cc_dst is wrong in some occurrences. > are targeted fixes: patch 1 helps with installing Fedora, and patch 3 > addresses something I noticed when reviewing the code. Patches 2 and 4 > are tests. I assume you are only scratching the surface with your fixes and we might be better off just doing CC_OP_ADDU / CC_OP_SUBU like CC_OP_ADD_32 / CC_OP_ADD_64 / ... to fix all issues involved. > > Best regards, > Ilya > > [1] https://gitlab.com/qemu-project/qemu/-/issues/1865#note_1545060658 > > Ilya Leoshkevich (4): > target/s390x: Fix CLC corrupting cc_src > tests/tcg/s390x: Test CLC with inaccessible second operand > target/s390x: Fix LAALG not updating cc_src > tests/tcg/s390x: Test LAALG with negative cc_src > > target/s390x/tcg/translate.c | 10 ++++--- > tests/tcg/s390x/Makefile.target | 2 ++ > tests/tcg/s390x/clc.c | 48 +++++++++++++++++++++++++++++++++ > tests/tcg/s390x/laalg.c | 27 +++++++++++++++++++ > 4 files changed, 84 insertions(+), 3 deletions(-) > create mode 100644 tests/tcg/s390x/clc.c > create mode 100644 tests/tcg/s390x/laalg.c > -- Cheers, David / dhildenb