From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FC0C433B4 for ; Tue, 13 Apr 2021 08:37:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E183261369 for ; Tue, 13 Apr 2021 08:37:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E183261369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWEYT-00055g-0u for qemu-devel@archiver.kernel.org; Tue, 13 Apr 2021 04:37:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWEUL-0001iu-06 for qemu-devel@nongnu.org; Tue, 13 Apr 2021 04:33:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWEUG-0005gD-B4 for qemu-devel@nongnu.org; Tue, 13 Apr 2021 04:33:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618302811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=laxEWDVu4J/YfzwBw2U8wtXrAVOKiZiO24hb8mLTMjg=; b=SnLpCYCmypxtmSGhSy2Jj/aYwNqR9Lr6Xj7YbxrWvhOLbVwAvXtgDjP0Mii0i4sEyiltfU 5UWmB4MKJ1EUOxA881ybrRkEasDUMEARiGRd3/xHc/bSvO4ZNeVk+vmHxqJFRu9nU+XiDN 09ZTx0QsSeArdBJKsqSYOaMj/Cl95HM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-iwMFTpoJN0iP5AMS1mJ2vg-1; Tue, 13 Apr 2021 04:33:29 -0400 X-MC-Unique: iwMFTpoJN0iP5AMS1mJ2vg-1 Received: by mail-wm1-f72.google.com with SMTP id g144-20020a1c20960000b029012983de0c8fso1437201wmg.7 for ; Tue, 13 Apr 2021 01:33:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=laxEWDVu4J/YfzwBw2U8wtXrAVOKiZiO24hb8mLTMjg=; b=auvo6P+vY2sbMwN5KldbB/zPYKlY3F8FnXCFnCXbjN2VA2IVs3zoVmgHt6blwDMrQA 9GYwqjMX+4ZPahJKZHBREFacsLLnkrOuJDRzJ/VtiQUtr757NoegNjuGbQ2wAg8DqF5/ zcNzSgKUAtebNgs5pIo1Tusm9izl/Y5W509NVmncsPp7coz4akrFCgRIX4S9pJ4RFQ7T QHiIivwzLa6OyGSmieVOTzQbP7QGFrZFTqMZZhXiiAVvId1+9O1rgZSc1qIJDKPYHH4u emMPG2IsdVKpf3v403L7PvFX+O5WXpGI/Bt2TYvoZyrVVqVU0i+21P5WGuNEtYWYbfUp 3T8g== X-Gm-Message-State: AOAM531bGx52nYVx3G4+hjscypuDGZFKCorbGQC8zZ1RyDdfYU9PhNLw OCPsvhVn49fFN1OhfDSj/ygxHlfEEFK2GVa4Gm9UBMzVUlAjAuLecQLICsrSyApRPsWstshhPbl 0etoxCkdnnxqUXc0= X-Received: by 2002:adf:f150:: with SMTP id y16mr9749391wro.186.1618302808271; Tue, 13 Apr 2021 01:33:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQ/5QoTDA/tAUlcrW14Vbs7XZIf34nou6OOo47EDRpThtCR62PZiGHHGXwiHgxiM3td7e+PA== X-Received: by 2002:adf:f150:: with SMTP id y16mr9749372wro.186.1618302808056; Tue, 13 Apr 2021 01:33:28 -0700 (PDT) Received: from [192.168.3.132] (p5b0c62e9.dip0.t-ipconnect.de. [91.12.98.233]) by smtp.gmail.com with ESMTPSA id i4sm1655960wmq.12.2021.04.13.01.33.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 01:33:27 -0700 (PDT) Subject: Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it From: David Hildenbrand To: Markus Armbruster References: <20210312173547.1283477-1-pbonzini@redhat.com> <20210312173547.1283477-3-pbonzini@redhat.com> <87im4q23v2.fsf@dusky.pond.sub.org> <07c08cc3-f3ca-6f7a-e5f7-d2d3ee8de79e@redhat.com> Organization: Red Hat Message-ID: Date: Tue, 13 Apr 2021 10:33:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <07c08cc3-f3ca-6f7a-e5f7-d2d3ee8de79e@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13.04.21 10:13, David Hildenbrand wrote: > On 13.04.21 06:41, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 12.03.21 18:35, Paolo Bonzini wrote: >>>> Emulators are currently using OptsVisitor (via user_creatable_add_opts) >>>> to parse the -object command line option. This has one extra feature, >>>> compared to keyval, which is automatic conversion of integers to lists >>>> as well as support for lists as repeated options: >>>> -object >>>> memory-backend-ram,id=pc.ram,size=1048576000,host-nodes=0,policy=bind >>>> So we cannot replace OptsVisitor with keyval right now. Still, this >>>> patch moves the user_creatable_add_opts logic to vl.c since it is >>>> not needed anywhere else, and makes it go through user_creatable_add_qapi. >>>> In order to minimize code changes, the predicate still takes a >>>> string. >>>> This can be changed later to use the ObjectType QAPI enum directly. >>>> >>> >>> Rebasing my "noreserve"[1] series on this, I get weird errors from >>> QEMU when specifying the new "reserve=off" option for a >>> memory-backend-ram: >>> >>> "Invalid parameter 'reserve'" >>> >>> And it looks like this is the case for any new properties. Poking >>> around, I fail to find what's causing this -- or how to unlock new >>> properties. What is the magic toggle to make it work? >>> >>> Thanks! >>> >>> [1] https://lkml.kernel.org/r/20210319101230.21531-1-david@redhat.com >> >> Wild guess: you didn't add your new properties in the QAPI schema. >> >> For a not-so-wild-guess, send us a git-fetch argument for your rebased >> series. >> > > Oh, there is qapi/qom.json -- maybe that does the trick. > > (I have mixed feelings about having to specify the same thing twice at > different locations) > > I'll have a look if that makes it fly. Yes, works just fine -- thanks! -- Thanks, David / dhildenb