From: Fiona Ebner <f.ebner@proxmox.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, vsementsov@yandex-team.ru,
jsnow@redhat.com, hreitz@redhat.com, kwolf@redhat.com,
pbonzini@redhat.com, t.lamprecht@proxmox.com
Subject: Re: [PATCH 3/3] blockdev: mirror: avoid potential deadlock when using iothread
Date: Fri, 20 Oct 2023 10:46:23 +0200 [thread overview]
Message-ID: <a7e6b65c-145c-4e5b-b2eb-7baac03ed78a@proxmox.com> (raw)
In-Reply-To: <20231019131936.414246-4-f.ebner@proxmox.com>
Am 19.10.23 um 15:19 schrieb Fiona Ebner:
> The bdrv_getlength() function is a generated co-wrapper and uses
> AIO_WAIT_WHILE() to wait for the spawned coroutine. AIO_WAIT_WHILE()
> expects the lock to be acquired exactly once.
>
> This can happen when the source node is explicitly specified as the
> @replaces parameter or if there is a filter on top of the source node.
Correction: this should read "or if the source node is a filter node".
next prev parent reply other threads:[~2023-10-20 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:19 [PATCH 0/3] fix a few blockjob-related deadlocks when using iothread Fiona Ebner
2023-10-19 13:19 ` [PATCH 1/3] blockjob: drop AioContext lock before calling bdrv_graph_wrlock() Fiona Ebner
2023-10-19 13:19 ` [PATCH 2/3] block: avoid potential deadlock during bdrv_graph_wrlock() in bdrv_close() Fiona Ebner
2023-10-19 13:19 ` [PATCH 3/3] blockdev: mirror: avoid potential deadlock when using iothread Fiona Ebner
2023-10-20 8:46 ` Fiona Ebner [this message]
2023-10-25 12:01 ` [PATCH 0/3] fix a few blockjob-related deadlocks " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7e6b65c-145c-4e5b-b2eb-7baac03ed78a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).