From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26635C433EF for ; Wed, 22 Sep 2021 10:03:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1535611B0 for ; Wed, 22 Sep 2021 10:03:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1535611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSz64-0002Sx-VX for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 06:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSz4Y-0001cc-16 for qemu-devel@nongnu.org; Wed, 22 Sep 2021 06:01:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSz4K-00036B-MZ for qemu-devel@nongnu.org; Wed, 22 Sep 2021 06:01:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632304893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RTRuldrya7LExhkbbi3PW8c+WO+Y3wSG3DR5T2tOs9w=; b=hdcKPNCC+Q/PujDu4/fguYEj4MyQeCt/qzt77U/MlTcWtR/53NQfb4etgKq+D6Fbkl7+SV lY3QJ/b/5GQJG4U/4xSmlCV/JOQSHegDznFPMgQsCqNgblPSjl/UIFhzluD2dsYxF+cuc8 4ixaYePyINw71Iws8Y4STX5EpPuD/0I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-tHg6S3J0PIGmnqWZ5eaf_A-1; Wed, 22 Sep 2021 06:01:32 -0400 X-MC-Unique: tHg6S3J0PIGmnqWZ5eaf_A-1 Received: by mail-wr1-f69.google.com with SMTP id f11-20020adfc98b000000b0015fedc2a8d4so1717028wrh.0 for ; Wed, 22 Sep 2021 03:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RTRuldrya7LExhkbbi3PW8c+WO+Y3wSG3DR5T2tOs9w=; b=BLiLeDP84e3OgQhBh8Ojmt7BMJNjTYA2BZ3wqf0I71IGcdDLhBRhBSPpCMSBnYc0mg 9uWB1gfTynYcte+2kS62FmAykH5LsORWLVupfGW04pZGRdkOq/BSemM5Lkq4bpFSSrck s2YjxkSdQicn0eXUqnr8B5hSoTVkbl5R9OM5pN4X3X5jUngQfLB9p+X6mvpn250oWdg9 WTpc/Kf8lO5hAcHkr59dd20Fx5tBIcvN70IK1FQPrZ3/mBaIalzw//LCSl/8Xu53ZizA eU11luY5zlKzjmBMJo6Ewqffhc4YRVzy2dfvIqOzcxCwpu/ZheMl8WzQoSpASSSgL6iR tnnw== X-Gm-Message-State: AOAM530yscSC7/UBxuuKR5eD7nSXnHwVpNLuCUbCkN1ppoDdVSTP3/Gc K2NokrvDAMqNBclaJ5qesTxoZkU8tbpnuBfY8T67N75lms0l1DYlcvyZvCu3GtwMpzPrqh43nHN ENsWMXYS7HImcQB8= X-Received: by 2002:adf:fac7:: with SMTP id a7mr40190177wrs.341.1632304890645; Wed, 22 Sep 2021 03:01:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2PqpimOxGRWezUENo4r1a4qujFSYoKBK/QYz+DVEaWXcmKDYi9THvxCrO1720zRP1dp6BDw== X-Received: by 2002:adf:fac7:: with SMTP id a7mr40190160wrs.341.1632304890474; Wed, 22 Sep 2021 03:01:30 -0700 (PDT) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id z19sm6770232wma.0.2021.09.22.03.01.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 03:01:29 -0700 (PDT) Subject: Re: [PATCH v3 26/35] acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end() instead of build_header() To: Igor Mammedov , qemu-devel@nongnu.org References: <20210907144814.741785-1-imammedo@redhat.com> <20210907144814.741785-27-imammedo@redhat.com> From: Eric Auger Message-ID: Date: Wed, 22 Sep 2021 12:01:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210907144814.741785-27-imammedo@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eauger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eauger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/7/21 4:48 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Eric > --- > v3: > * s/acpi_init_table|acpi_table_composed/acpi_table_begin|acpi_table_end/ > > CC: marcel.apfelbaum@gmail.com > CC: kraxel@redhat.com > --- > hw/i386/acpi-microvm.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c > index 1a0f77b911..196d318499 100644 > --- a/hw/i386/acpi-microvm.c > +++ b/hw/i386/acpi-microvm.c > @@ -113,16 +113,16 @@ build_dsdt_microvm(GArray *table_data, BIOSLinker *linker, > Aml *dsdt, *sb_scope, *scope, *pkg; > bool ambiguous; > Object *isabus; > + AcpiTable table = { .sig = "DSDT", .rev = 2, .oem_id = x86ms->oem_id, > + .oem_table_id = x86ms->oem_table_id }; > > isabus = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous); > assert(isabus); > assert(!ambiguous); > > + acpi_table_begin(&table, table_data); > dsdt = init_aml_allocator(); > > - /* Reserve space for header */ > - acpi_data_push(dsdt->buf, sizeof(AcpiTableHeader)); > - > sb_scope = aml_scope("_SB"); > fw_cfg_add_acpi_dsdt(sb_scope, x86ms->fw_cfg); > isa_build_aml(ISA_BUS(isabus), sb_scope); > @@ -144,11 +144,10 @@ build_dsdt_microvm(GArray *table_data, BIOSLinker *linker, > aml_append(scope, aml_name_decl("_S5", pkg)); > aml_append(dsdt, scope); > > - /* copy AML table into ACPI tables blob and patch header there */ > + /* copy AML bytecode into ACPI tables blob */ > g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); > - build_header(linker, table_data, > - (void *)(table_data->data + table_data->len - dsdt->buf->len), > - "DSDT", dsdt->buf->len, 2, x86ms->oem_id, x86ms->oem_table_id); > + > + acpi_table_end(linker, &table); > free_aml_allocator(); > } > >