From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
vsementsov@virtuozzo.com, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] blockdev: reduce aio_context locked sections in bitmap add/remove
Date: Mon, 15 Jul 2019 13:31:41 +0200 [thread overview]
Message-ID: <a7f03345-4d36-f5b7-c133-980f466c20c5@redhat.com> (raw)
In-Reply-To: <20190708220502.12977-2-jsnow@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
On 09.07.19 00:05, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> Commit 0a6c86d024c52 returned these locks back to add/remove
> functionality, to protect from intersection of persistent bitmap
> related IO with other IO. But other bitmap-related functions called
> here are unrelated to the problem, and there are no needs to keep these
> calls inside critical sections.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> blockdev.c | 30 +++++++++++++-----------------
> 1 file changed, 13 insertions(+), 17 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-15 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 22:04 [Qemu-devel] [PATCH v3 0/3] qapi: block-dirty-bitmap-remove transaction action John Snow
2019-07-08 22:05 ` [Qemu-devel] [PATCH v3 1/3] blockdev: reduce aio_context locked sections in bitmap add/remove John Snow
2019-07-15 11:31 ` Max Reitz [this message]
2019-07-08 22:05 ` [Qemu-devel] [PATCH v3 2/3] qapi: implement block-dirty-bitmap-remove transaction action John Snow
2019-07-15 11:40 ` Max Reitz
2019-07-15 18:21 ` John Snow
2019-07-24 13:58 ` Vladimir Sementsov-Ogievskiy
2019-07-24 16:13 ` John Snow
2019-07-08 22:05 ` [Qemu-devel] [PATCH v3 3/3] iotests: test bitmap moving inside 254 John Snow
2019-07-15 11:44 ` Max Reitz
2019-07-15 19:48 ` [Qemu-devel] [PATCH v3 0/3] qapi: block-dirty-bitmap-remove transaction action John Snow
2019-07-24 11:12 ` Vladimir Sementsov-Ogievskiy
2019-07-24 12:52 ` John Snow
2019-07-26 17:26 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7f03345-4d36-f5b7-c133-980f466c20c5@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).