From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, mrezanin@redhat.com,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S
Date: Mon, 26 Jun 2023 16:54:12 +0200 [thread overview]
Message-ID: <a807476d-fe97-3c05-32d2-371b0a82b92a@linux.ibm.com> (raw)
In-Reply-To: <20230626132138.87668-4-thuth@redhat.com>
Am 26.06.23 um 15:21 schrieb Thomas Huth:
> diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
> index 29b0a9ece0..47ef6e8aa8 100644
> --- a/pc-bios/s390-ccw/start.S
> +++ b/pc-bios/s390-ccw/start.S
> @@ -120,3 +120,8 @@ external_new_mask:
> .quad 0x0000000180000000
> io_new_mask:
> .quad 0x0000000180000000
> +
> +.bss
> +
> + .align 16
> + .lcomm stack,STACK_SIZE
IIRC, the ELF ABI defines the stack to be 8 byte aligned, but 16 certainly does not hurt.
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
next prev parent reply other threads:[~2023-06-26 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 13:21 [PATCH 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S Thomas Huth
2023-06-26 13:21 ` [PATCH 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-26 13:40 ` Cédric Le Goater
2023-06-26 13:21 ` [PATCH 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Thomas Huth
2023-06-26 13:41 ` Cédric Le Goater
2023-06-26 14:46 ` Christian Borntraeger
2023-06-26 13:21 ` [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-26 14:54 ` Christian Borntraeger [this message]
2023-06-26 15:25 ` Richard Henderson
2023-06-27 6:55 ` Thomas Huth
2023-06-26 13:21 ` [PATCH 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a807476d-fe97-3c05-32d2-371b0a82b92a@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=clg@kaod.org \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).