qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Sandesh Patel <sandesh.patel@nutanix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Rob Scheepens <rob.scheepens@nutanix.com>,
	Prerna Saxena <confluence@nutanix.com>,
	Alexander Graf <agraf@csgraf.de>
Subject: Re: More than 255 vcpus Windows VM setup without viommu ?
Date: Sat, 28 Sep 2024 15:59:32 +0100	[thread overview]
Message-ID: <a80c99b0e10e71a5a301c884d699eeaff3893349.camel@infradead.org> (raw)
In-Reply-To: <B75A5788-630B-4898-8758-52B57D3D5895@nutanix.com>

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

On Tue, 2024-07-02 at 05:17 +0000, Sandesh Patel wrote:
> 
> The error is due to invalid MSIX routing entry passed to KVM.
> 
> The VM boots fine if we attach a vIOMMU but adding a vIOMMU can
> potentially result in IO performance loss in guest.
> I was interested to know if someone could boot a large Windows VM by
> some other means like kvm-msi-ext-dest-id.

I think I may (with Alex Graf's suggestion) have found the Windows bug
with Intel IOMMU.

It looks like when interrupt remapping is enabled with an AMD CPU,
Windows *assumes* it can generate AMD-style MSI messages even if the
IOMMU is an Intel one. If we put a little hack into the IOMMU interrupt
remapping to make it interpret an AMD-style message, Windows seems to
boot at least a little bit further than it did before...


--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3550,9 +3550,14 @@ static int vtd_interrupt_remap_msi(IntelIOMMUState *iommu,
 
     /* This is compatible mode. */
     if (addr.addr.int_mode != VTD_IR_INT_FORMAT_REMAP) {
-        memcpy(translated, origin, sizeof(*origin));
-        goto out;
-    }
+        if (0) {
+            memcpy(translated, origin, sizeof(*origin));
+            goto out;
+        }
+        /* Pretend it's an AMD-format remappable MSI (Yay Windows!) */
+        index = origin->data & 0x7ff;
+        printf("Compat mode index 0x%x\n", index);
+    } else
 
     index = addr.addr.index_h << 15 | addr.addr.index_l;
 


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

  parent reply	other threads:[~2024-09-28 15:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  5:17 More than 255 vcpus Windows VM setup without viommu ? Sandesh Patel
2024-07-02  9:04 ` David Woodhouse
2024-07-03 16:01   ` Sandesh Patel
2024-07-08  9:13     ` David Woodhouse
2024-07-11  7:26       ` David Woodhouse
2024-07-11 11:23         ` David Woodhouse
2024-07-11 11:52           ` Sandesh Patel
2024-07-16  5:13             ` Sandesh Patel
2024-07-24  9:22               ` David Woodhouse
2024-08-01 10:28         ` Sandesh Patel
2024-09-28 14:59 ` David Woodhouse [this message]
2024-09-30 15:50   ` David Woodhouse
2024-10-02 11:33     ` Igor Mammedov
2024-10-02 15:30       ` David Woodhouse
2024-10-01 13:33   ` Daniel P. Berrangé
2024-10-01 16:37     ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2024-07-02  7:20 Sandesh Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a80c99b0e10e71a5a301c884d699eeaff3893349.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=agraf@csgraf.de \
    --cc=confluence@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.scheepens@nutanix.com \
    --cc=sandesh.patel@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).