From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: jsnow@redhat.com, ehabkost@redhat.com, crosa@redhat.com
Subject: Re: [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements
Date: Thu, 6 Feb 2020 15:52:48 +0100 [thread overview]
Message-ID: <a8238c8a-92d6-3870-ff8c-1d499fe8e295@redhat.com> (raw)
In-Reply-To: <20200204141111.3207-1-wainersm@redhat.com>
On 2/4/20 3:11 PM, Wainer dos Santos Moschetta wrote:
> I started fixing an issue on exception handling which in some places
> currently use the deprecated (in Python 3.3) `socket.error`. Then I
> ended up delinting the module code and making some improvements.
>
> Changes in v2:
> - Rebased to master. No conflicts.
> - Added docstring describing the allowed value of the new `timeout`
> option in accept() (patch 03) [jsnow]
> - Set the new `timeout` option to 15.0 by default [philmd]
>
> v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg667479.html
>
> Git:
> - Tree: https://github.com/wainersm/qemu
> - Branch: python_qmp_sockets_error-v2
>
> CI:
> - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/645583812
> Jobs failures aren't related with these changes
>
>
> Wainer dos Santos Moschetta (5):
> python/qemu: qmp: Replace socket.error with OSError
> python/qemu: Delint the qmp module
> python/qemu: qmp: Make accept()'s timeout configurable
> python/qemu: qmp: Make QEMUMonitorProtocol a context manager
> python/qemu: qmp: Remove unnused attributes
>
> python/qemu/qmp.py | 97 +++++++++++++++++++++++++++++++++-------------
> 1 file changed, 71 insertions(+), 26 deletions(-)
>
Patches 3 and 4 applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next
prev parent reply other threads:[~2020-02-06 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 14:11 [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements Wainer dos Santos Moschetta
2020-02-04 14:11 ` [PATCH v2 1/5] python/qemu: qmp: Replace socket.error with OSError Wainer dos Santos Moschetta
2020-02-04 14:11 ` [PATCH v2 2/5] python/qemu: Delint the qmp module Wainer dos Santos Moschetta
2020-02-04 14:11 ` [PATCH v2 3/5] python/qemu: qmp: Make accept()'s timeout configurable Wainer dos Santos Moschetta
2020-02-05 23:28 ` John Snow
2020-02-04 14:11 ` [PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager Wainer dos Santos Moschetta
2020-02-05 23:43 ` John Snow
2020-02-04 14:11 ` [PATCH v2 5/5] python/qemu: qmp: Remove unnused attributes Wainer dos Santos Moschetta
2020-02-06 14:52 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8238c8a-92d6-3870-ff8c-1d499fe8e295@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).