From: Thomas Huth <thuth@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/2] tests: fix usb-hcd-ehci-test compilation
Date: Thu, 26 Sep 2019 13:49:23 +0200 [thread overview]
Message-ID: <a83aca7b-ffd2-3c0d-7ab7-7b72ad4dc225@redhat.com> (raw)
In-Reply-To: <20190926111955.17276-2-marcandre.lureau@redhat.com>
On 26/09/2019 13.19, Marc-André Lureau wrote:
> Fixes commit
> e5758de4e836c3b2edc2befd904651fc6967d74f ("tests/libqtest: Make
> qtest_qmp_device_add/del independent from global_qtest")
>
> and commit
> dd210749727530cdef7c335040edbf81c3c5d041 ("tests/libqtest: Use
> libqtest-single.h in tests that require global_qtest").
>
> Cc: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/usb-hcd-ehci-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/usb-hcd-ehci-test.c b/tests/usb-hcd-ehci-test.c
> index 8bc3e44189..5251d539e9 100644
> --- a/tests/usb-hcd-ehci-test.c
> +++ b/tests/usb-hcd-ehci-test.c
> @@ -8,7 +8,7 @@
> */
>
> #include "qemu/osdep.h"
> -#include "libqtest.h"
> +#include "libqtest-single.h"
> #include "libqos/pci-pc.h"
> #include "hw/usb/uhci-regs.h"
> #include "hw/usb/ehci-regs.h"
> @@ -139,7 +139,7 @@ static void pci_ehci_port_3_hotplug(void)
>
> static void pci_ehci_port_hotplug(void)
> {
> - usb_test_hotplug("ich9-ehci-1", "3", pci_ehci_port_3_hotplug);
> + usb_test_hotplug(global_qtest, "ich9-ehci-1", "3", pci_ehci_port_3_hotplug);
> }
Thanks, I've queued both patches to my qtest-next branch now:
https://gitlab.com/huth/qemu/commits/qtest-next
Thomas
next prev parent reply other threads:[~2019-09-26 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 11:19 [PATCH 0/2] Fix ehci-test Marc-André Lureau
2019-09-26 11:19 ` [PATCH 1/2] tests: fix usb-hcd-ehci-test compilation Marc-André Lureau
2019-09-26 11:23 ` Laurent Vivier
2019-09-26 11:49 ` Thomas Huth [this message]
2019-09-26 11:19 ` [PATCH 2/2] tests: fix echi/ehci typo Marc-André Lureau
2019-09-26 11:24 ` Laurent Vivier
2019-09-26 11:39 ` Thomas Huth
2019-09-26 12:53 ` Philippe Mathieu-Daudé
2019-09-27 6:23 ` [PATCH 0/2] Fix ehci-test no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a83aca7b-ffd2-3c0d-7ab7-7b72ad4dc225@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).