From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests: docker: support mxe-based mingw builds
Date: Wed, 19 Aug 2020 12:42:44 +0200 [thread overview]
Message-ID: <a83d1d0d-3f5e-8aa1-801a-aaf844c29587@redhat.com> (raw)
In-Reply-To: <20200819082013.GB69261@redhat.com>
On 19/08/20 10:20, Daniel P. Berrangé wrote:
> We already have docker containers with MXE based on Debian:
>
> debian-win32-cross.docker
> debian-win64-cross.docker
>
> your image uses a different naming convention, and puts both
> 32 and 64 bit in the same image.
Yeah, that's what test-mingw expects.
> I feel like we should have the Ubuntu variant follow the same
> structure and naming as the Debian variant for consistency.
My patch follows the Fedora variant, so that test-mingw runs. That
ensures that NSIS is covered as well. One possibility could be:
- create fedora-win*-cross dockerfiles
- add ENV FEATURES $FEATURES mingw to the win*-cross dockerfiles
- look for the feature in test-full and test-quick, and run "make
installer" if so.
- drop test-mingw completely, and adjust Patchew to use
docker-test-quick@fedora-win{32,64}-cross instead
Paolo
next prev parent reply other threads:[~2020-08-19 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 8:02 [PATCH] tests: docker: support mxe-based mingw builds Paolo Bonzini
2020-08-19 8:13 ` Marc-André Lureau
2020-08-19 8:20 ` Daniel P. Berrangé
2020-08-19 10:42 ` Paolo Bonzini [this message]
2020-08-19 11:09 ` Daniel P. Berrangé
2020-08-19 11:41 ` Paolo Bonzini
2020-08-19 8:59 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a83d1d0d-3f5e-8aa1-801a-aaf844c29587@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).